Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move SSSS storage setup to key backup setup time #13895

Closed
dbkr opened this issue Jun 2, 2020 · 2 comments · Fixed by matrix-org/matrix-react-sdk#5219
Closed

Move SSSS storage setup to key backup setup time #13895

dbkr opened this issue Jun 2, 2020 · 2 comments · Fixed by matrix-org/matrix-react-sdk#5219
Assignees
@jryans
Labels
A-E2EE-Cross-Signing

Comments

@dbkr
Copy link
Member

dbkr commented Jun 2, 2020 •
edited by jryans
Loading

We now want to have cross-signing work out-of-the-box but delay setting up SSSS storage until the user has started interacting with e2e as we currently do for key backup.

  • Disentangle cross-signing and SSSS storage setup in the js-sdk
  • Create cross-signing keys automatically on login / registration if they're not present. Save all private key parts (including the master key) in the cache.
  • Delay setting up SSSS storage (and therefore recovery key creation) until later. We can use the old key backup nag screens for this (at least initially), ie. we should set up key backup and SSSS storage as one.

Related to #13825
@dbkr dbkr mentioned this issue Jun 2, 2020
Closed
@dbkr dbkr self-assigned this Jun 15, 2020
@dbkr dbkr added this to In Review in Web App Team Jun 15, 2020
@dbkr dbkr moved this from In Review to In Progress in Web App Team Jun 15, 2020
@dbkr dbkr removed their assignment Jun 15, 2020
@dbkr dbkr removed this from In Progress in Web App Team Jun 15, 2020
@dbkr
Copy link
Member Author

dbkr commented Jun 15, 2020

Blocked on #13581

@manuroe manuroe mentioned this issue Jun 17, 2020
Closed
This was referenced Jun 30, 2020
Closed
Open
@jryans jryans self-assigned this Jul 21, 2020
@jryans jryans added this to In Progress in Web App Team via automation Jul 21, 2020
@jryans
Copy link
Collaborator

jryans commented Jul 29, 2020

Updated original comment to remove the MSK wiping step, as we appear to have agreed to keep it on all platforms.

jryans added a commit to matrix-org/matrix-js-sdk that referenced this issue Aug 27, 2020
@jryans
Untangle cross-signing and secret storage
f19d76b 
This untangles cross-signing and secret storage setup into separate path that
can be invoked independently. There is no functional change with this patch, but
instead this just separates one giant monster API into two.

Part of element-hq/element-web#13895
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Aug 27, 2020
@jryans
Add secret storage readiness checks
a732c55 
This visits all places that were checking for cross-siging readiness and adapts
them to also check for secret storage readiness if needed.

Part of element-hq/element-web#13895
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Aug 27, 2020
@jryans
Migrate to new, separate APIs for cross-signing and secret storage
4a807f9 
This migrates to the new JS SDK APIs, which now use separate paths for
cross-signing and secret storage setup. There should be no functional change
here.

Part of element-hq/element-web#13895
This was referenced Aug 27, 2020
Merged
Merged
Closed
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Sep 3, 2020
@jryans
Tweak Security settings section headers
da6cc5c 
This brings us slightly closer to the version Design is working from in terms of
section naming.

Prep for element-hq/element-web#13895
@jryans jryans mentioned this issue Sep 3, 2020
Merged
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Sep 15, 2020
@jryans
Place cross-signing action buttons on a single row
53662d2 
Part of element-hq/element-web#13895
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Sep 15, 2020
@jryans
Clarify diagnostic about keys in storage
5a77d88 
Part of element-hq/element-web#13895
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Sep 16, 2020
@jryans
Recheck security status on room encryption change
83292f7 
This ensures we are alerted when you first interact with an encrypted room.

Part of element-hq/element-web#13895
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Sep 16, 2020
@jryans
Remove room recovery reminder
cbcad86 
The Secure Backup toast replaces this with better UX.

Part of element-hq/element-web#13895
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Sep 16, 2020
@jryans
Delay encryption setup toasts until encrypted rooms present
491d125 
Part of element-hq/element-web#13895
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Sep 16, 2020
@jryans
Adjust main encryption toast to reference Secure Backup
36170bf 
This adjusts the main toast to focus on Secure Backup as suggested in designs.

Part of element-hq/element-web#13895
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Sep 16, 2020
@jryans
Place cross-signing action buttons on a single row
3277d41 
Part of element-hq/element-web#13895
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Sep 16, 2020
@jryans
Clarify diagnostic about keys in storage
f0434ae 
Part of element-hq/element-web#13895
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Sep 16, 2020
@jryans
Recheck security status on room encryption change
98275ba 
This ensures we are alerted when you first interact with an encrypted room.

Part of element-hq/element-web#13895
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Sep 16, 2020
@jryans
Remove room recovery reminder
77129e2 
The Secure Backup toast replaces this with better UX.

Part of element-hq/element-web#13895
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Sep 16, 2020
@jryans
Delay encryption setup toasts until encrypted rooms present
430862d 
Part of element-hq/element-web#13895
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Sep 16, 2020
@jryans
Adjust main encryption toast to reference Secure Backup
8b24898 
This adjusts the main toast to focus on Secure Backup as suggested in designs.

Part of element-hq/element-web#13895
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Sep 16, 2020
@jryans
Place cross-signing action buttons on a single row
3259ab1 
Part of element-hq/element-web#13895
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Sep 16, 2020
@jryans
Clarify diagnostic about keys in storage
685878a 
Part of element-hq/element-web#13895
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Sep 16, 2020
@jryans
Recheck security status on room encryption change
ada00a3 
This ensures we are alerted when you first interact with an encrypted room.

Part of element-hq/element-web#13895
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Sep 16, 2020
@jryans
Remove room recovery reminder
26b465f 
The Secure Backup toast replaces this with better UX.

Part of element-hq/element-web#13895
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Sep 16, 2020
@jryans
Delay encryption setup toasts until encrypted rooms present
6130d9e 
Part of element-hq/element-web#13895
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Sep 16, 2020
@jryans
Adjust main encryption toast to reference Secure Backup
7a5b0a9 
This adjusts the main toast to focus on Secure Backup as suggested in designs.

Part of element-hq/element-web#13895
@jryans jryans mentioned this issue Sep 16, 2020
Merged
@jryans jryans moved this from In Progress to In Review in Web App Team Sep 16, 2020
@jryans jryans mentioned this issue Sep 16, 2020
Open
Web App Team automation moved this from In Review to In Test Sep 18, 2020
@mlaily mlaily mentioned this issue Sep 27, 2020
Closed
@jryans jryans mentioned this issue Oct 9, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jryans jryans

Labels
A-E2EE-Cross-Signing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Defer encryption setup until first E2EE room matrix-org/matrix-react-sdk
2 participants
@jryans @dbkr