Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign room list tile notification dropdown #13961

Closed
t3chguy opened this issue Jun 9, 2020 · 4 comments · Fixed by matrix-org/matrix-react-sdk#4858
Closed

Redesign room list tile notification dropdown #13961

t3chguy opened this issue Jun 9, 2020 · 4 comments · Fixed by matrix-org/matrix-react-sdk#4858
Assignees
@t3chguy
Labels
A-Notifications A-Room-List Z-FTUE-Notifications
Projects
Room List v2

Comments

@t3chguy
Copy link
Member

t3chguy commented Jun 9, 2020

https://www.figma.com/file/M15i7l4PSPY1B5M7Zhu80H/Notifications?node-id=381%3A4544
@turt2live
Copy link
Member

ftr the room list tile is undergoing heavy changes in the new room list. Would recommend waiting for its context menu to land before the notifications bell does.

turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Jun 10, 2020
@turt2live
Add a context menu to rooms in the new room list
0755b4c 
The tag options are not implemented out of concern for diff size. 

This splits the context menu classes out to a new "iconized" style which is common across a number of context menus, including the UserMenu.

Some of the badge/sublist styles had to change to better accommodate the menu icon lining up.

This also contains the framework required for element-hq/element-web#13961
@turt2live turt2live mentioned this issue Jun 10, 2020
Merged
@fedon

This comment has been minimized.

Sign in to view
@t3chguy t3chguy added this to Stable & shippable in Room List v2 Jun 27, 2020
@t3chguy t3chguy mentioned this issue Jun 27, 2020
Closed
@turt2live turt2live moved this from Stable & shippable to Track 1 (temp) in Room List v2 Jun 28, 2020
@turt2live
Copy link
Member

Unblocked for now: Wedge it in next to the context menu, include all 4 current states (against proposed notification changes).

@turt2live turt2live moved this from Stable and shippable: Stability Track to In progress (dev) in Room List v2 Jun 29, 2020
@t3chguy t3chguy mentioned this issue Jun 29, 2020
Merged
3 tasks
@nadonomy
Copy link
Contributor

Straw man proposal for improving todays interactions here:

https://www.figma.com/file/rHnynEgrePUtXVear8rGT0/34-Room-List?node-id=1814%3A181

Designs will be dressed up properly soon.

@nadonomy nadonomy mentioned this issue Jun 30, 2020
Closed
@t3chguy t3chguy added this to In Progress in Web App Team via automation Jul 1, 2020
@t3chguy t3chguy moved this from In Progress to In Review in Web App Team Jul 1, 2020
Web App Team automation moved this from In Review to In Test Jul 1, 2020
Room List v2 automation moved this from In progress (dev) to Done 🎉 Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
A-Notifications A-Room-List Z-FTUE-Notifications
Projects
Room List v2
  
Done 🎉
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Room Tile context menu, notifications, indicator and placement matrix-org/matrix-react-sdk
4 participants
@turt2live @t3chguy @fedon @nadonomy