Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New room list: Muted rooms are being ordered as if they aren't muted in importance mode #14362

Closed
turt2live opened this issue Jul 7, 2020 · 0 comments · Fixed by matrix-org/matrix-react-sdk#4949
Closed

New room list: Muted rooms are being ordered as if they aren't muted in importance mode #14362

turt2live opened this issue Jul 7, 2020 · 0 comments · Fixed by matrix-org/matrix-react-sdk#4949
Assignees
@turt2live
Labels
A-Room-List T-Defect
Projects
Room List v2

Comments

@turt2live
Copy link
Member

No description provided.

@turt2live turt2live added this to TODO in Room List v2 via automation Jul 7, 2020
@turt2live turt2live moved this from TODO to Stable and shippable: Stability Track in Room List v2 Jul 7, 2020
@turt2live turt2live self-assigned this Jul 7, 2020
@turt2live turt2live moved this from Stable and shippable: Stability Track to In progress (dev) in Room List v2 Jul 7, 2020
@turt2live turt2live added this to In Progress in Web App Team via automation Jul 7, 2020
@turt2live turt2live moved this from In progress (dev) to Stable and shippable: Stability Track in Room List v2 Jul 9, 2020
@turt2live turt2live assigned turt2live and unassigned turt2live Jul 10, 2020
@turt2live turt2live moved this from Stable and shippable: Stability Track to In progress (dev) in Room List v2 Jul 10, 2020
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Jul 10, 2020
@turt2live
Convert ImportanceAlgorithm over to using NotificationColor instead
3062d14 
Fixes element-hq/element-web#14362 implicitly

By re-using constructs we already have, we don't need to invent code which figures it out.
@turt2live turt2live mentioned this issue Jul 10, 2020
Merged
@turt2live turt2live moved this from In Progress to In Review in Web App Team Jul 10, 2020
Web App Team automation moved this from In Review to In Test Jul 12, 2020
Room List v2 automation moved this from In progress (dev) to Done 🎉 Jul 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
A-Room-List T-Defect
Projects
Room List v2
  
Done 🎉
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Convert ImportanceAlgorithm over to using NotificationColor instead matrix-org/matrix-react-sdk
2 participants
@jryans @turt2live