Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We're leaking mx_Tooltip_wrappers? #14700

Closed
ara4n opened this issue Jul 22, 2020 · 2 comments · Fixed by matrix-org/matrix-react-sdk#5055
Closed

We're leaking mx_Tooltip_wrappers? #14700

ara4n opened this issue Jul 22, 2020 · 2 comments · Fixed by matrix-org/matrix-react-sdk#5055
Assignees
Labels

Comments

@ara4n
Copy link
Member

ara4n commented Jul 22, 2020

I just noticed I have ~300 mx_Tooltip_wrapper divs as children of my body tag. Surely this isn't right?

Screenshot 2020-07-22 at 11 44 15

@ara4n ara4n added the T-Defect label Jul 22, 2020
@t3chguy
Copy link
Member

t3chguy commented Jul 22, 2020

We have one in the DOM for each possible tooltip in the view you are currently in. Because of CSS animations to simplify having to inject into the DOM and then later update the CSS to show them

@t3chguy
Copy link
Member

t3chguy commented Jul 22, 2020

This is a relatively hard thing to resolve as it is possible to have multiple tooltips at the same time due to Fields showing tooltips too

@t3chguy t3chguy self-assigned this Jul 28, 2020
@t3chguy t3chguy added this to In Progress in Web App Team via automation Jul 28, 2020
@t3chguy t3chguy moved this from In Progress to In Review in Web App Team Jul 28, 2020
Web App Team automation moved this from In Review to In Test Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants