Fix TextWithTooltip "leaking" tooltip wrappers #5055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way our Tooltip component works is hugely flawed, it uses two expensive operations and in one of its mode is very happy to litter loads of Tooltip wrappers into the DOM.
Fixes element-hq/element-web#14700
Alleviates / Fixes element-hq/element-web#14707
This PR moves to only mounting the Tooltip component when it will be shown like every other area we use it in the app.
Ideally we'd make a much smarter Tooltip component but that's outside of scope for these issues.