Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tooltips account for about 1/5th of the first app render #14707

Closed
turt2live opened this issue Jul 22, 2020 · 2 comments · Fixed by matrix-org/matrix-react-sdk#5055
Closed

Tooltips account for about 1/5th of the first app render #14707

turt2live opened this issue Jul 22, 2020 · 2 comments · Fixed by matrix-org/matrix-react-sdk#5055
Assignees
@t3chguy
Labels
A-Performance T-Defect T-Task Tasks for the team like planning

Comments

@turt2live
Copy link
Member

It requires use of getBoundingClientRect which triggers a forced style recalc and a forced layout change, multiplied by the potentially hundreds of tooltips in the room list alone.

We should find a better way of positioning them that doesn't cause so many forced renders during the initial app mount.
@turt2live turt2live added T-Defect T-Task Tasks for the team like planning A-Performance labels Jul 22, 2020
@turt2live
Copy link
Member Author

image

so many tooltips

@t3chguy t3chguy self-assigned this Jul 28, 2020
@t3chguy t3chguy added this to In Progress in Web App Team via automation Jul 28, 2020
@t3chguy t3chguy moved this from In Progress to In Review in Web App Team Jul 28, 2020
@t3chguy t3chguy mentioned this issue Jul 28, 2020
Merged
@t3chguy
Copy link
Member

t3chguy commented Jul 28, 2020

With the above PR the app render cost will go away but the forced style recalc will still happen on hover of a tooltip-enabled component.

Web App Team automation moved this from In Review to In Test Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
A-Performance T-Defect T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix TextWithTooltip "leaking" tooltip wrappers matrix-org/matrix-react-sdk
2 participants
@turt2live @t3chguy