Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bridge info settings tab: Clickable url to targeted room from external_url field is disappeared #16032

Closed
MurzNN opened this issue Dec 25, 2020 · 1 comment

Comments

@MurzNN
Copy link
Contributor

MurzNN commented Dec 25, 2020

Description

Via merge Bridge info settings tab from @Half-Shot there was added page with bridge info, that uses MSC2346: Bridge information state event.

But this page now didn't shows the clickable link to targeted room from content.channel.external_url field of m.bridge state event, as displayed in merge screenshot, seems something broken?

This link is very useful for quickly jump from Matrix room to same room in native interface of bridged protocol.

Steps to reproduce

For example, Gitter bridge in Microsoft/vscode room was filled this field by right value "external_url": "https://gitter.im/Microsoft/vscode", here is full state event:

{
  "content": {
    "bridgebot": "@gitter-badger:gitter.im",
    "channel": {
      "avatar_url": "mxc://gitter.im/eae049e13477aada11ae48458e89a673c5c5aee1",
      "displayname": "Microsoft/vscode",
      "external_url": "https://gitter.im/Microsoft/vscode",
      "id": "55a40f2a5e0d51bd787b439c"
    },
    "protocol": {
      "avatar_url": "mxc://gitter.im/5ca06a9ec041815b7bfe089ec2733507753aa43c",
      "displayname": "Gitter",
      "external_url": "https://gitter.im/",
      "id": "gitter"
    }
  },
  "origin_server_ts": 1608274509929,
  "sender": "@gitter-badger:gitter.im",
  "state_key": "",
  "type": "uk.half-shot.bridge",
  "unsigned": {
    "age": 381213202
  },
  "event_id": "$KqMoNwFVQIpE3jVYNimmOypo3mFWrzXwLmwE-uPbBF4",
  "room_id": "!fxZxLvWcibVaFxWjxq:gitter.im"
}

And in Element interface I didn't see this link, here is screenshot:
image

Can we give back, or re-invent this very useful link in interface?

Version information

  • URL: develop.element.io
@Half-Shot
Copy link
Member

This is fixed by matrix-org/matrix-react-sdk#5454

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants