Bridge info settings tab #3693
Merged
Bridge info settings tab #3693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Half-Shot
force-pushed
the
hs/bridge-info
branch
from
35841a6
to
6225e40
Compare
|
Notable changes from today:
|
turt2live
requested changes
Jan 2, 2020
|
Note that in 50e19ba I made the change to remove "bot user" from the text. Due to matrix being how it is, we cannot determine if the sender of the state event is a bot user. To err on the side of paranoia, let's not imply they are a bot user in the text to avoid any weirdness. Users should hopefully be able to distinguish a user from a bot by the displayname/mxid, or at least not be intentionally misled. |
Half-Shot
commented
Jan 3, 2020
|
|
||
| if (shouldShowBridgeIcon) { | ||
| tabs.push(new Tab( | ||
| _td("Bridge Info"), |
There was a problem hiding this comment.
I wonder if this should just be "Bridges", or "Connected Bridges", or "Integrations"
turt2live
approved these changes
Jan 3, 2020
turt2live
reviewed
Jan 5, 2020
|
@turt2live we good now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a room settings tab that shows the connected bridges in a room, which is my proof of concept on the client side for MSC2346.
EDIT: Added a few more details to the page
Paired with element-hq/element-web#11778 - TR