Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show image resolution in lightbox #17014

Open
t3chguy opened this issue Apr 20, 2021 · 5 comments
Open

Show image resolution in lightbox #17014

t3chguy opened this issue Apr 20, 2021 · 5 comments
Labels
A-Light-Box UI when viewing an image A-Media O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users T-Enhancement X-Needs-Design

Comments

@t3chguy
Copy link
Member

t3chguy commented Apr 20, 2021

The new lightbox is lightyears ahead of the old one, thanks @niquewoodhouse & @SimonBrandner - but I miss my stats for nerds :'(

@niquewoodhouse
Copy link

@t3chguy this probably seems really obvious to you but would you mind just explaining why this is important/when its important to know and how important it is compared to other things on the screen.

I'm just struggling to see where it fits in the hierarchy, and not seeing it in competitor apps made me think its not actually helpful. Any insight would be really welcome, thanks :)

@t3chguy
Copy link
Member Author

t3chguy commented Apr 20, 2021

Fair point about it not being in competitors, I find it important to save me having to download it or inspecting the event to find that out, e.g if I am considering using something as a wallpaper/screensaver I'd need to know the resolution to see whether its good enough

It isn't super important, I think it could be in the subscript text with the date/time at
image

e.g

$DATE $TIME - $INFO

Maybe the size could just be on the download tooltip, I don't think they need to be super accessible

image

@waclaw66
Copy link
Contributor

@SimonBrandner Buttons are show over those in background, it looks messy...

obrazek

@SimonBrandner
Copy link
Contributor

@waclaw66, I've heard that this could happen but there wasn't a clear reproduction case. Could you please open a new issue and add some steps to reproduce it? I'll try to look into it

@robintown robintown changed the title New image lightbox lost image size & resolution metadata Show image resolution in lightbox May 20, 2022
@robintown
Copy link
Member

We now show the file size, but still not the resolution

@SimonBrandner SimonBrandner added T-Enhancement O-Occasional Affects or can be seen by some users regularly or most users rarely A-Light-Box UI when viewing an image A-Media labels May 20, 2022
@andybalaam andybalaam added the S-Tolerable Low/no impact on users label May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Light-Box UI when viewing an image A-Media O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users T-Enhancement X-Needs-Design
Projects
None yet
Development

No branches or pull requests

6 participants