quick theme toggle not working

[HarHarLinks]

Description

This thing

isn't working for me at all.

The light theme will become selected in the menu like this

but theme is only applied when switching via this menu.

#17581 could be related.

Steps to reproduce

• click light/dark theme quick toggle in the top left user menu thing
• potentially use these labs settings, especially custom themes
• no idea since when this is, i don't normally use this feature

Logs being sent: yes

Version information

• Platform: desktop

For the desktop app:

• OS: Arch
• Version: aur/element-desktop-nightly-bin 2021060702-1

[Zachinquarantine]

It seems, for me on Windows running element build 1.7.30, that it will only work once you close off the app completely and reopen it.

[robintown]

This is because of setting watchers being broken, which is fixed in matrix-org/matrix-react-sdk#6143. However as the scope of that PR has grown, I think it might make more sense to just cherry-pick commit 40d2f8228f4d2a3f7f386d320c42ae1970932ee4 from it.