Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrading a room to set it as restricted can be slow #19146

Closed
novocaine opened this issue Sep 23, 2021 · 3 comments · Fixed by matrix-org/matrix-react-sdk#6919
Closed

Upgrading a room to set it as restricted can be slow #19146

novocaine opened this issue Sep 23, 2021 · 3 comments · Fixed by matrix-org/matrix-react-sdk#6919
Assignees
@t3chguy
Labels
A-Room-Upgrades A-Spaces Spaces, groups, communities O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@novocaine
Copy link
Contributor

Steps to reproduce

Room settings -> Security and Privacy -> Access, set to spaces members for a room requiring an upgrade, then upgrade. Leave invite all members set enabled (the default).

This was for the Element Web Internal room.

What happened?

I had to wait 1-2 minutes for a loading spinner - if I didn't know better, I'd think things had broken and would have given up.

I expected it to not take this long, or if it does, show me some progress so I can see things are moving along.

Operating system

OS X

Browser information

Chrome

URL for webapp

develop.element.io

Homeserver

matrix.org

Have you submitted a rageshake?

No
@novocaine novocaine added T-Defect A-Spaces Spaces, groups, communities S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely and removed S-Minor Impairs non-critical functionality or suitable workarounds exist labels Sep 23, 2021
@t3chguy
Copy link
Member

t3chguy commented Sep 28, 2021 •
edited
Loading

So the upgrade process has a lot of work to do, especially if you choose to invite exiting users.

  1. Upgrade the room itself (one slow API hit)
  2. Wait for that room to come down /sync
  3. Invite all users if user asked for it (default on) (one API hit per user)
  4. Re-link the room into all parents where we can (two API hits per relationship)

@novocaine
Copy link
Contributor Author

Can we show a progress meter..? @niquewoodhouse

@niquewoodhouse
Copy link

Can we show a progress meter..? @niquewoodhouse

Sure, sounds good to me if you're waiting around. We've got the progress bar we use on adding rooms to a space/migrating a community to a space. Using the same UI seems most reasonable to me.

image

@t3chguy t3chguy self-assigned this Oct 8, 2021
@t3chguy t3chguy mentioned this issue Oct 8, 2021
Merged
su-ex added a commit to SchildiChat/element-web that referenced this issue Oct 25, 2021
@su-ex
Merge tag 'v1.9.3' into sc
d37fc69 
* Convert the "Cryptography" settings panel to an HTML table to assist screen reader users. ([\element-hq#6968](matrix-org/matrix-react-sdk#6968)). Contributed by [andybalaam](https://github.com/andybalaam).
* Swap order of private space creation and tweak copy ([\element-hq#6967](matrix-org/matrix-react-sdk#6967)). Fixes element-hq#18768 and element-hq#18768.
* Add spacing to Room settings - Notifications subsection ([\#6962](matrix-org/matrix-react-sdk#6962)). Contributed by [CicadaCinema](https://github.com/CicadaCinema).
* Use HTML tables for some tabular user interface areas, to assist with screen reader use ([\element-hq#6955](matrix-org/matrix-react-sdk#6955)). Contributed by [andybalaam](https://github.com/andybalaam).
* Fix space invite edge cases ([\element-hq#6884](matrix-org/matrix-react-sdk#6884)). Fixes element-hq#19010 element-hq#17345 and element-hq#19010.
* Allow options to cascade kicks/bans throughout spaces ([\element-hq#6829](matrix-org/matrix-react-sdk#6829)). Fixes element-hq#18969 and element-hq#18969.
* Make public space alias field mandatory again ([\element-hq#6921](matrix-org/matrix-react-sdk#6921)). Fixes element-hq#19003 and element-hq#19003.
* Add progress bar to restricted room upgrade dialog ([\element-hq#6919](matrix-org/matrix-react-sdk#6919)). Fixes element-hq#19146 and element-hq#19146.
* Add customisation point for visibility of invites and room creation ([\element-hq#6922](matrix-org/matrix-react-sdk#6922)). Fixes element-hq#19331 and element-hq#19331.
* Inhibit `Unable to get validated threepid` error during UIA ([\element-hq#6928](matrix-org/matrix-react-sdk#6928)). Fixes element-hq#18883 and element-hq#18883.
* Tweak room list skeleton UI height and behaviour ([\element-hq#6926](matrix-org/matrix-react-sdk#6926)). Fixes element-hq#18231 element-hq#16581 and element-hq#18231.
* If public room creation fails, retry without publishing it ([\#6872](matrix-org/matrix-react-sdk#6872)). Fixes element-hq#19194 and element-hq#19194. Contributed by [AndrewFerr](https://github.com/AndrewFerr).
* Iterate invite your teammates to Space view ([\element-hq#6925](matrix-org/matrix-react-sdk#6925)). Fixes element-hq#18772 and element-hq#18772.
* Make placeholder more grey when no input ([\element-hq#6840](matrix-org/matrix-react-sdk#6840)). Fixes element-hq#17243 and element-hq#17243. Contributed by [wlach](https://github.com/wlach).
* Respect tombstones in locally known rooms for Space children ([\element-hq#6906](matrix-org/matrix-react-sdk#6906)). Fixes element-hq#19246 element-hq#19256 and element-hq#19246.
* Improve emoji shortcodes generated from annotations ([\element-hq#6907](matrix-org/matrix-react-sdk#6907)). Fixes element-hq#19304 and element-hq#19304.
* Hide kick & ban options in UserInfo when looking at own profile ([\element-hq#6911](matrix-org/matrix-react-sdk#6911)). Fixes element-hq#19066 and element-hq#19066.
* Add progress bar to Community to Space migration tool ([\element-hq#6887](matrix-org/matrix-react-sdk#6887)). Fixes element-hq#19216 and element-hq#19216.
* Fix leave space cancel button exploding ([\element-hq#6966](matrix-org/matrix-react-sdk#6966)).
* Fix edge case behaviour of the space join spinner for guests ([\element-hq#6972](matrix-org/matrix-react-sdk#6972)). Fixes element-hq#19359 and element-hq#19359.
* Convert emoticon to emoji at the end of a line on send even if the cursor isn't there ([\element-hq#6965](matrix-org/matrix-react-sdk#6965)). Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix text overflows button on Home page ([\#6898](matrix-org/matrix-react-sdk#6898)). Fixes element-hq#19180 and element-hq#19180. Contributed by [oliver-pham](https://github.com/oliver-pham).
* Space Room View should react to join rule changes down /sync ([\#6945](matrix-org/matrix-react-sdk#6945)). Fixes element-hq#19390 and element-hq#19390.
* Hide leave section button if user isn't in the room e.g peeking ([\element-hq#6920](matrix-org/matrix-react-sdk#6920)). Fixes element-hq#17410 and element-hq#17410.
* Fix bug where room list would get stuck showing no rooms ([\element-hq#6939](matrix-org/matrix-react-sdk#6939)). Fixes element-hq#19373 and element-hq#19373.
* Update room settings dialog title when room name changes ([\element-hq#6916](matrix-org/matrix-react-sdk#6916)). Fixes element-hq#17480 and element-hq#17480. Contributed by [psrpinto](https://github.com/psrpinto).
* Fix editing losing emote-ness and rainbow-ness of messages ([\element-hq#6931](matrix-org/matrix-react-sdk#6931)). Fixes element-hq#19350 and element-hq#19350.
* Remove semicolon from notifications panel ([\element-hq#6930](matrix-org/matrix-react-sdk#6930)). Contributed by [robintown](https://github.com/robintown).
* Prevent profile image in left panel's backdrop from being selected ([\element-hq#6924](matrix-org/matrix-react-sdk#6924)). Contributed by [rom4nik](https://github.com/rom4nik).
* Validate that the phone number verification field is filled before allowing user to submit ([\element-hq#6918](matrix-org/matrix-react-sdk#6918)). Fixes element-hq#19316 and element-hq#19316. Contributed by [VFermat](https://github.com/VFermat).
* Updated how save button becomes disabled in room settings to listen for all fields instead of the most recent ([\element-hq#6917](matrix-org/matrix-react-sdk#6917)). Contributed by [LoganArnett](https://github.com/LoganArnett).
* Use FocusLock around ContextMenus to simplify focus management ([\element-hq#6311](matrix-org/matrix-react-sdk#6311)). Fixes element-hq#19259 and element-hq#19259.
* Fix space hierarchy pagination ([\element-hq#6908](matrix-org/matrix-react-sdk#6908)). Fixes element-hq#19276 and element-hq#19276.
* Fix spaces keyboard shortcuts not working for last space ([\element-hq#6909](matrix-org/matrix-react-sdk#6909)). Fixes element-hq#19255 and element-hq#19255.
* Use fallback avatar only for DMs with 2 people. ([\element-hq#6895](matrix-org/matrix-react-sdk#6895)). Fixes element-hq#18747 and element-hq#18747. Contributed by [andybalaam](https://github.com/andybalaam).
su-ex added a commit to SchildiChat/matrix-react-sdk that referenced this issue Oct 25, 2021
@su-ex
Merge tag 'v3.33.0' into sc
f32fd48 
* Convert the "Cryptography" settings panel to an HTML table to assist screen reader users. ([\matrix-org#6968](matrix-org#6968)). Contributed by [andybalaam](https://github.com/andybalaam).
* Swap order of private space creation and tweak copy ([\matrix-org#6967](matrix-org#6967)). Fixes element-hq/element-web#18768 and element-hq/element-web#18768.
* Add spacing to Room settings - Notifications subsection ([\matrix-org#6962](matrix-org#6962)). Contributed by [CicadaCinema](https://github.com/CicadaCinema).
* Use HTML tables for some tabular user interface areas, to assist with screen reader use ([\matrix-org#6955](matrix-org#6955)). Contributed by [andybalaam](https://github.com/andybalaam).
* Fix space invite edge cases ([\matrix-org#6884](matrix-org#6884)). Fixes element-hq/element-web#19010 element-hq/element-web#17345 and element-hq/element-web#19010.
* Allow options to cascade kicks/bans throughout spaces ([\matrix-org#6829](matrix-org#6829)). Fixes element-hq/element-web#18969 and element-hq/element-web#18969.
* Make public space alias field mandatory again ([\matrix-org#6921](matrix-org#6921)). Fixes element-hq/element-web#19003 and element-hq/element-web#19003.
* Add progress bar to restricted room upgrade dialog ([\matrix-org#6919](matrix-org#6919)). Fixes element-hq/element-web#19146 and element-hq/element-web#19146.
* Add customisation point for visibility of invites and room creation ([\matrix-org#6922](matrix-org#6922)). Fixes element-hq/element-web#19331 and element-hq/element-web#19331.
* Inhibit `Unable to get validated threepid` error during UIA ([\matrix-org#6928](matrix-org#6928)). Fixes element-hq/element-web#18883 and element-hq/element-web#18883.
* Tweak room list skeleton UI height and behaviour ([\matrix-org#6926](matrix-org#6926)). Fixes element-hq/element-web#18231 element-hq/element-web#16581 and element-hq/element-web#18231.
* If public room creation fails, retry without publishing it ([\matrix-org#6872](matrix-org#6872)). Fixes element-hq/element-web#19194 and element-hq/element-web#19194. Contributed by [AndrewFerr](https://github.com/AndrewFerr).
* Iterate invite your teammates to Space view ([\matrix-org#6925](matrix-org#6925)). Fixes element-hq/element-web#18772 and element-hq/element-web#18772.
* Make placeholder more grey when no input ([\matrix-org#6840](matrix-org#6840)). Fixes element-hq/element-web#17243 and element-hq/element-web#17243. Contributed by [wlach](https://github.com/wlach).
* Respect tombstones in locally known rooms for Space children ([\matrix-org#6906](matrix-org#6906)). Fixes element-hq/element-web#19246 element-hq/element-web#19256 and element-hq/element-web#19246.
* Improve emoji shortcodes generated from annotations ([\matrix-org#6907](matrix-org#6907)). Fixes element-hq/element-web#19304 and element-hq/element-web#19304.
* Hide kick & ban options in UserInfo when looking at own profile ([\matrix-org#6911](matrix-org#6911)). Fixes element-hq/element-web#19066 and element-hq/element-web#19066.
* Add progress bar to Community to Space migration tool ([\matrix-org#6887](matrix-org#6887)). Fixes element-hq/element-web#19216 and element-hq/element-web#19216.
* Fix leave space cancel button exploding ([\matrix-org#6966](matrix-org#6966)).
* Fix edge case behaviour of the space join spinner for guests ([\matrix-org#6972](matrix-org#6972)). Fixes element-hq/element-web#19359 and element-hq/element-web#19359.
* Convert emoticon to emoji at the end of a line on send even if the cursor isn't there ([\matrix-org#6965](matrix-org#6965)). Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix text overflows button on Home page ([\matrix-org#6898](matrix-org#6898)). Fixes element-hq/element-web#19180 and element-hq/element-web#19180. Contributed by [oliver-pham](https://github.com/oliver-pham).
* Space Room View should react to join rule changes down /sync ([\matrix-org#6945](matrix-org#6945)). Fixes element-hq/element-web#19390 and element-hq/element-web#19390.
* Hide leave section button if user isn't in the room e.g peeking ([\matrix-org#6920](matrix-org#6920)). Fixes element-hq/element-web#17410 and element-hq/element-web#17410.
* Fix bug where room list would get stuck showing no rooms ([\matrix-org#6939](matrix-org#6939)). Fixes element-hq/element-web#19373 and element-hq/element-web#19373.
* Update room settings dialog title when room name changes ([\matrix-org#6916](matrix-org#6916)). Fixes element-hq/element-web#17480 and element-hq/element-web#17480. Contributed by [psrpinto](https://github.com/psrpinto).
* Fix editing losing emote-ness and rainbow-ness of messages ([\matrix-org#6931](matrix-org#6931)). Fixes element-hq/element-web#19350 and element-hq/element-web#19350.
* Remove semicolon from notifications panel ([\matrix-org#6930](matrix-org#6930)). Contributed by [robintown](https://github.com/robintown).
* Prevent profile image in left panel's backdrop from being selected ([\matrix-org#6924](matrix-org#6924)). Contributed by [rom4nik](https://github.com/rom4nik).
* Validate that the phone number verification field is filled before allowing user to submit ([\matrix-org#6918](matrix-org#6918)). Fixes element-hq/element-web#19316 and element-hq/element-web#19316. Contributed by [VFermat](https://github.com/VFermat).
* Updated how save button becomes disabled in room settings to listen for all fields instead of the most recent ([\matrix-org#6917](matrix-org#6917)). Contributed by [LoganArnett](https://github.com/LoganArnett).
* Use FocusLock around ContextMenus to simplify focus management ([\matrix-org#6311](matrix-org#6311)). Fixes element-hq/element-web#19259 and element-hq/element-web#19259.
* Fix space hierarchy pagination ([\matrix-org#6908](matrix-org#6908)). Fixes element-hq/element-web#19276 and element-hq/element-web#19276.
* Fix spaces keyboard shortcuts not working for last space ([\matrix-org#6909](matrix-org#6909)). Fixes element-hq/element-web#19255 and element-hq/element-web#19255.
* Use fallback avatar only for DMs with 2 people. ([\matrix-org#6895](matrix-org#6895)). Fixes element-hq/element-web#18747 and element-hq/element-web#18747. Contributed by [andybalaam](https://github.com/andybalaam).
su-ex added a commit to SchildiChat/element-desktop that referenced this issue Oct 25, 2021
@su-ex
Merge tag 'v1.9.3' into sc
89dbad2 
* Convert the "Cryptography" settings panel to an HTML table to assist screen reader users. ([\#6968](matrix-org/matrix-react-sdk#6968)). Contributed by [andybalaam](https://github.com/andybalaam).
* Swap order of private space creation and tweak copy ([\#6967](matrix-org/matrix-react-sdk#6967)). Fixes element-hq/element-web#18768 and element-hq/element-web#18768.
* Add spacing to Room settings - Notifications subsection ([\#6962](matrix-org/matrix-react-sdk#6962)). Contributed by [CicadaCinema](https://github.com/CicadaCinema).
* Use HTML tables for some tabular user interface areas, to assist with screen reader use ([\#6955](matrix-org/matrix-react-sdk#6955)). Contributed by [andybalaam](https://github.com/andybalaam).
* Fix space invite edge cases ([\#6884](matrix-org/matrix-react-sdk#6884)). Fixes element-hq/element-web#19010 element-hq/element-web#17345 and element-hq/element-web#19010.
* Allow options to cascade kicks/bans throughout spaces ([\#6829](matrix-org/matrix-react-sdk#6829)). Fixes element-hq/element-web#18969 and element-hq/element-web#18969.
* Make public space alias field mandatory again ([\#6921](matrix-org/matrix-react-sdk#6921)). Fixes element-hq/element-web#19003 and element-hq/element-web#19003.
* Add progress bar to restricted room upgrade dialog ([\#6919](matrix-org/matrix-react-sdk#6919)). Fixes element-hq/element-web#19146 and element-hq/element-web#19146.
* Add customisation point for visibility of invites and room creation ([\#6922](matrix-org/matrix-react-sdk#6922)). Fixes element-hq/element-web#19331 and element-hq/element-web#19331.
* Inhibit `Unable to get validated threepid` error during UIA ([\#6928](matrix-org/matrix-react-sdk#6928)). Fixes element-hq/element-web#18883 and element-hq/element-web#18883.
* Tweak room list skeleton UI height and behaviour ([\#6926](matrix-org/matrix-react-sdk#6926)). Fixes element-hq/element-web#18231 element-hq/element-web#16581 and element-hq/element-web#18231.
* If public room creation fails, retry without publishing it ([\#6872](matrix-org/matrix-react-sdk#6872)). Fixes element-hq/element-web#19194 and element-hq/element-web#19194. Contributed by [AndrewFerr](https://github.com/AndrewFerr).
* Iterate invite your teammates to Space view ([\#6925](matrix-org/matrix-react-sdk#6925)). Fixes element-hq/element-web#18772 and element-hq/element-web#18772.
* Make placeholder more grey when no input ([\#6840](matrix-org/matrix-react-sdk#6840)). Fixes element-hq/element-web#17243 and element-hq/element-web#17243. Contributed by [wlach](https://github.com/wlach).
* Respect tombstones in locally known rooms for Space children ([\#6906](matrix-org/matrix-react-sdk#6906)). Fixes element-hq/element-web#19246 element-hq/element-web#19256 and element-hq/element-web#19246.
* Improve emoji shortcodes generated from annotations ([\#6907](matrix-org/matrix-react-sdk#6907)). Fixes element-hq/element-web#19304 and element-hq/element-web#19304.
* Hide kick & ban options in UserInfo when looking at own profile ([\#6911](matrix-org/matrix-react-sdk#6911)). Fixes element-hq/element-web#19066 and element-hq/element-web#19066.
* Add progress bar to Community to Space migration tool ([\#6887](matrix-org/matrix-react-sdk#6887)). Fixes element-hq/element-web#19216 and element-hq/element-web#19216.
* Fix leave space cancel button exploding ([\#6966](matrix-org/matrix-react-sdk#6966)).
* Fix edge case behaviour of the space join spinner for guests ([\#6972](matrix-org/matrix-react-sdk#6972)). Fixes element-hq/element-web#19359 and element-hq/element-web#19359.
* Convert emoticon to emoji at the end of a line on send even if the cursor isn't there ([\#6965](matrix-org/matrix-react-sdk#6965)). Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix text overflows button on Home page ([\#6898](matrix-org/matrix-react-sdk#6898)). Fixes element-hq/element-web#19180 and element-hq/element-web#19180. Contributed by [oliver-pham](https://github.com/oliver-pham).
* Space Room View should react to join rule changes down /sync ([\#6945](matrix-org/matrix-react-sdk#6945)). Fixes element-hq/element-web#19390 and element-hq/element-web#19390.
* Hide leave section button if user isn't in the room e.g peeking ([\#6920](matrix-org/matrix-react-sdk#6920)). Fixes element-hq/element-web#17410 and element-hq/element-web#17410.
* Fix bug where room list would get stuck showing no rooms ([\#6939](matrix-org/matrix-react-sdk#6939)). Fixes element-hq/element-web#19373 and element-hq/element-web#19373.
* Update room settings dialog title when room name changes ([\#6916](matrix-org/matrix-react-sdk#6916)). Fixes element-hq/element-web#17480 and element-hq/element-web#17480. Contributed by [psrpinto](https://github.com/psrpinto).
* Fix editing losing emote-ness and rainbow-ness of messages ([\#6931](matrix-org/matrix-react-sdk#6931)). Fixes element-hq/element-web#19350 and element-hq/element-web#19350.
* Remove semicolon from notifications panel ([\#6930](matrix-org/matrix-react-sdk#6930)). Contributed by [robintown](https://github.com/robintown).
* Prevent profile image in left panel's backdrop from being selected ([\#6924](matrix-org/matrix-react-sdk#6924)). Contributed by [rom4nik](https://github.com/rom4nik).
* Validate that the phone number verification field is filled before allowing user to submit ([\#6918](matrix-org/matrix-react-sdk#6918)). Fixes element-hq/element-web#19316 and element-hq/element-web#19316. Contributed by [VFermat](https://github.com/VFermat).
* Updated how save button becomes disabled in room settings to listen for all fields instead of the most recent ([\#6917](matrix-org/matrix-react-sdk#6917)). Contributed by [LoganArnett](https://github.com/LoganArnett).
* Use FocusLock around ContextMenus to simplify focus management ([\#6311](matrix-org/matrix-react-sdk#6311)). Fixes element-hq/element-web#19259 and element-hq/element-web#19259.
* Fix space hierarchy pagination ([\#6908](matrix-org/matrix-react-sdk#6908)). Fixes element-hq/element-web#19276 and element-hq/element-web#19276.
* Fix spaces keyboard shortcuts not working for last space ([\#6909](matrix-org/matrix-react-sdk#6909)). Fixes element-hq/element-web#19255 and element-hq/element-web#19255.
* Use fallback avatar only for DMs with 2 people. ([\#6895](matrix-org/matrix-react-sdk#6895)). Fixes element-hq/element-web#18747 and element-hq/element-web#18747. Contributed by [andybalaam](https://github.com/andybalaam).
williamkray added a commit to williamkray/element-web that referenced this issue Nov 9, 2021
@williamkray
Merge tag 'v1.9.3' into develop
fc62e0a 
* Convert the "Cryptography" settings panel to an HTML table to assist screen reader users. ([\element-hq#6968](matrix-org/matrix-react-sdk#6968)). Contributed by [andybalaam](https://github.com/andybalaam).
* Swap order of private space creation and tweak copy ([\element-hq#6967](matrix-org/matrix-react-sdk#6967)). Fixes element-hq#18768 and element-hq#18768.
* Add spacing to Room settings - Notifications subsection ([\#6962](matrix-org/matrix-react-sdk#6962)). Contributed by [CicadaCinema](https://github.com/CicadaCinema).
* Use HTML tables for some tabular user interface areas, to assist with screen reader use ([\element-hq#6955](matrix-org/matrix-react-sdk#6955)). Contributed by [andybalaam](https://github.com/andybalaam).
* Fix space invite edge cases ([\element-hq#6884](matrix-org/matrix-react-sdk#6884)). Fixes element-hq#19010 element-hq#17345 and element-hq#19010.
* Allow options to cascade kicks/bans throughout spaces ([\element-hq#6829](matrix-org/matrix-react-sdk#6829)). Fixes element-hq#18969 and element-hq#18969.
* Make public space alias field mandatory again ([\element-hq#6921](matrix-org/matrix-react-sdk#6921)). Fixes element-hq#19003 and element-hq#19003.
* Add progress bar to restricted room upgrade dialog ([\element-hq#6919](matrix-org/matrix-react-sdk#6919)). Fixes element-hq#19146 and element-hq#19146.
* Add customisation point for visibility of invites and room creation ([\element-hq#6922](matrix-org/matrix-react-sdk#6922)). Fixes element-hq#19331 and element-hq#19331.
* Inhibit `Unable to get validated threepid` error during UIA ([\element-hq#6928](matrix-org/matrix-react-sdk#6928)). Fixes element-hq#18883 and element-hq#18883.
* Tweak room list skeleton UI height and behaviour ([\element-hq#6926](matrix-org/matrix-react-sdk#6926)). Fixes element-hq#18231 element-hq#16581 and element-hq#18231.
* If public room creation fails, retry without publishing it ([\#6872](matrix-org/matrix-react-sdk#6872)). Fixes element-hq#19194 and element-hq#19194. Contributed by [AndrewFerr](https://github.com/AndrewFerr).
* Iterate invite your teammates to Space view ([\element-hq#6925](matrix-org/matrix-react-sdk#6925)). Fixes element-hq#18772 and element-hq#18772.
* Make placeholder more grey when no input ([\element-hq#6840](matrix-org/matrix-react-sdk#6840)). Fixes element-hq#17243 and element-hq#17243. Contributed by [wlach](https://github.com/wlach).
* Respect tombstones in locally known rooms for Space children ([\element-hq#6906](matrix-org/matrix-react-sdk#6906)). Fixes element-hq#19246 element-hq#19256 and element-hq#19246.
* Improve emoji shortcodes generated from annotations ([\element-hq#6907](matrix-org/matrix-react-sdk#6907)). Fixes element-hq#19304 and element-hq#19304.
* Hide kick & ban options in UserInfo when looking at own profile ([\element-hq#6911](matrix-org/matrix-react-sdk#6911)). Fixes element-hq#19066 and element-hq#19066.
* Add progress bar to Community to Space migration tool ([\element-hq#6887](matrix-org/matrix-react-sdk#6887)). Fixes element-hq#19216 and element-hq#19216.
* Fix leave space cancel button exploding ([\element-hq#6966](matrix-org/matrix-react-sdk#6966)).
* Fix edge case behaviour of the space join spinner for guests ([\element-hq#6972](matrix-org/matrix-react-sdk#6972)). Fixes element-hq#19359 and element-hq#19359.
* Convert emoticon to emoji at the end of a line on send even if the cursor isn't there ([\element-hq#6965](matrix-org/matrix-react-sdk#6965)). Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix text overflows button on Home page ([\#6898](matrix-org/matrix-react-sdk#6898)). Fixes element-hq#19180 and element-hq#19180. Contributed by [oliver-pham](https://github.com/oliver-pham).
* Space Room View should react to join rule changes down /sync ([\#6945](matrix-org/matrix-react-sdk#6945)). Fixes element-hq#19390 and element-hq#19390.
* Hide leave section button if user isn't in the room e.g peeking ([\element-hq#6920](matrix-org/matrix-react-sdk#6920)). Fixes element-hq#17410 and element-hq#17410.
* Fix bug where room list would get stuck showing no rooms ([\element-hq#6939](matrix-org/matrix-react-sdk#6939)). Fixes element-hq#19373 and element-hq#19373.
* Update room settings dialog title when room name changes ([\element-hq#6916](matrix-org/matrix-react-sdk#6916)). Fixes element-hq#17480 and element-hq#17480. Contributed by [psrpinto](https://github.com/psrpinto).
* Fix editing losing emote-ness and rainbow-ness of messages ([\element-hq#6931](matrix-org/matrix-react-sdk#6931)). Fixes element-hq#19350 and element-hq#19350.
* Remove semicolon from notifications panel ([\element-hq#6930](matrix-org/matrix-react-sdk#6930)). Contributed by [robintown](https://github.com/robintown).
* Prevent profile image in left panel's backdrop from being selected ([\element-hq#6924](matrix-org/matrix-react-sdk#6924)). Contributed by [rom4nik](https://github.com/rom4nik).
* Validate that the phone number verification field is filled before allowing user to submit ([\element-hq#6918](matrix-org/matrix-react-sdk#6918)). Fixes element-hq#19316 and element-hq#19316. Contributed by [VFermat](https://github.com/VFermat).
* Updated how save button becomes disabled in room settings to listen for all fields instead of the most recent ([\element-hq#6917](matrix-org/matrix-react-sdk#6917)). Contributed by [LoganArnett](https://github.com/LoganArnett).
* Use FocusLock around ContextMenus to simplify focus management ([\element-hq#6311](matrix-org/matrix-react-sdk#6311)). Fixes element-hq#19259 and element-hq#19259.
* Fix space hierarchy pagination ([\element-hq#6908](matrix-org/matrix-react-sdk#6908)). Fixes element-hq#19276 and element-hq#19276.
* Fix spaces keyboard shortcuts not working for last space ([\element-hq#6909](matrix-org/matrix-react-sdk#6909)). Fixes element-hq#19255 and element-hq#19255.
* Use fallback avatar only for DMs with 2 people. ([\element-hq#6895](matrix-org/matrix-react-sdk#6895)). Fixes element-hq#18747 and element-hq#18747. Contributed by [andybalaam](https://github.com/andybalaam).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
A-Room-Upgrades A-Spaces Spaces, groups, communities O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add progress bar to restricted room upgrade dialog matrix-org/matrix-react-sdk
4 participants
@novocaine @niquewoodhouse @t3chguy @SimonBrandner