Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make themes & code highlight colours aware of each other #19478

Closed
dbkr opened this issue Oct 22, 2021 · 1 comment
Closed

Make themes & code highlight colours aware of each other #19478

dbkr opened this issue Oct 22, 2021 · 1 comment
Labels
A-Themes-Custom Custom theme variables or support A-Themes-Official Official themes (light, dark) A-Timeline T-Task Tasks for the team like planning

Comments

@dbkr
Copy link
Member

dbkr commented Oct 22, 2021

Themes can have light or dark background and our code highlighting library, highlight.js, has light and dark themes, but we just include the github light theme, overriding some of the colours. This leads to bugs like #19476

We should make them aware of each other somehow, eg. having a light/dark discriminator for themes so we can pick an appropriate highlight.js theme, or perhaps just don't use highlight.js's themes at all and define the colours in our own themes.

There might also be other areas of the app where we need to make this distinction.

@dbkr dbkr added T-Task Tasks for the team like planning A-Themes-Custom Custom theme variables or support A-Themes-Official Official themes (light, dark) labels Oct 22, 2021
@dbkr
Copy link
Member Author

dbkr commented Oct 22, 2021

Never mind - the include of the github light theme was presumably a leftover from something and was the cause of that bug. We include light/dark highlight.js themes from the light/dark themes respectively.

@dbkr dbkr closed this as completed Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Themes-Custom Custom theme variables or support A-Themes-Official Official themes (light, dark) A-Timeline T-Task Tasks for the team like planning
Projects
None yet
Development

No branches or pull requests

2 participants