Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread summary ignores text decorations #19945

Open
HarHarLinks opened this issue Nov 29, 2021 · 7 comments
Open

Thread summary ignores text decorations #19945

HarHarLinks opened this issue Nov 29, 2021 · 7 comments
Assignees
Labels
A-Message-Previews A-Threads O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Needs-Design Z-Labs

Comments

@HarHarLinks
Copy link

HarHarLinks commented Nov 29, 2021

Steps to reproduce

image

Outcome

What did you expect?

not everything is needed, but decorations like strikethrough change the meaning and should be reflected

What happened instead?

Looks to me like it's filtered similarly or the same way previews in the room list are. Some stuff gets HTML-escaped, e.g. < > but if it actually reuses the room list preview code then that has been fixed on develop.
image
image
image
Reactions aren't shown at all, but I don't know what I expect there.

Operating system

w10

Application version

Element version: 1.9.5 Olm version: 3.2.3

How did you install the app?

element.io

Homeserver

No response

Will you send logs?

No

@SimonBrandner SimonBrandner added A-Threads A-Timeline O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist X-Needs-Design labels Nov 30, 2021
@kittykat kittykat added the Z-Labs label Dec 8, 2021
@daniellekirkwood
Copy link
Contributor

thanks for raising this issue!

@janogarcia Should the Thread Summary have the same treatment as message previews in the left panel, or should we be striving for a different solution here? Previews in the Room list view do not show text decorations, but they do show reactions.

@HarHarLinks
Copy link
Author

HarHarLinks commented Dec 13, 2021

Previews in the Room list view do not show text decorations

However, both room list and thread summary should respect certain decorations, like hiding spoilers or strike through. What I mean to say is that it's possibly okay to reuse the same "preview code", but it needs a bit of polish for such features whichever way it is done. The same rules also apply to notifications, by the way.

but they do show reactions.

Isn't this a labs feature?
image
Still I agree with the notion that it needs to be decided how to handle them.

@t3chguy
Copy link
Member

t3chguy commented Dec 14, 2021

Related #16330

@daniellekirkwood daniellekirkwood changed the title Thread summary ignores text decorations Thread summary ignores text decorations & Room list previews ignore threads Jan 19, 2022
@germain-gg germain-gg changed the title Thread summary ignores text decorations & Room list previews ignore threads Thread summary ignores text decorations Feb 7, 2022
@germain-gg
Copy link
Contributor

This issue about room list previews is tracked as part of #19615

@janogarcia
Copy link

I'd just add that, as a first step, I documented the inconsistencies for "rendering content types and formatting styles" across all platforms. Also, opened issues for each platform to somehow address the inconsistencies.

For this first iteration we have taken the current implementation for Web as the reference implementation. The next step will be figuring out how to improve that spec, and make it more usable, which includes revisiting how we render those content types and formatting styles (such as those mentioned by HarHarLinks) in those contexts.

@HarHarLinks
Copy link
Author

revisiting how we render those content types and formatting styles

I don't have a link, but there has been talk about the idea to outsource the markdown compiler to a common custom rust library, which would possibly also integrate here

@quazgar
Copy link

quazgar commented Jul 14, 2022

This bug affecting spoiler blurring will become more urgent as thread responses are enabled by more and more users.

Bug reproduced in:
Element version: 1.11.0
Olm version: 3.2.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Message-Previews A-Threads O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Needs-Design Z-Labs
Projects
None yet
Development

No branches or pull requests

8 participants