Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reply canceled when permalink is clicked #21462

Closed
aaronraimist opened this issue Mar 18, 2022 · 0 comments · Fixed by matrix-org/matrix-react-sdk#8114
Closed

Reply canceled when permalink is clicked #21462

aaronraimist opened this issue Mar 18, 2022 · 0 comments · Fixed by matrix-org/matrix-react-sdk#8114
Assignees
@t3chguy
Labels
A-Composer A-Replies reply A-Timeline O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression

Comments

@aaronraimist
Copy link
Collaborator

aaronraimist commented Mar 18, 2022 •
edited
Loading

Steps to reproduce

  1. Open a room
  2. Click the reply button next to a message
  3. Start typing a reply
  4. Click on an existing reply (opening the permalink to that message) or click on a permalink because you see a message you want to refer to

Outcome

What did you expect?

The timeline scrolls to that spot

What happened instead?

The timeline scrolls to that spot AND my reply is canceled.

The composer still knows what I've written but I am no longer replying to the message I had been replying to.

Context

This bug means I often accidentally send a normal message that I thought was a reply and then I have to delete it and resend it to ensure that I ping the person. This is a long standing annoyance I've had with replies.

Operating system

No response

Browser information

No response

URL for webapp

No response

Application version

1.10.7

Homeserver

No response

Will you send logs?

No
@aaronraimist aaronraimist added T-Defect S-Minor Impairs non-critical functionality or suitable workarounds exist A-Replies reply A-Composer O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Mar 18, 2022
@aaronraimist aaronraimist changed the title Reply disapears when permalink is clicked Reply canceled when permalink is clicked Mar 18, 2022
@aaronraimist aaronraimist mentioned this issue Mar 18, 2022
Closed
@t3chguy t3chguy self-assigned this Mar 22, 2022
@t3chguy t3chguy added this to In Review in Web App Team Mar 22, 2022
@t3chguy t3chguy mentioned this issue Mar 22, 2022
Merged
Web App Team automation moved this from In Review to In Test Mar 23, 2022
kegsay added a commit to matrix-org/matrix-react-sdk that referenced this issue Sep 14, 2022
@kegsay
bugfix: fix in-reply-to previews not disappearing when swapping rooms
e5b081e 
This was caused by the fix for another issue:
  - element-hq/element-web#21462

Both bugs are now fixed with cypress regression tests.
@kegsay kegsay mentioned this issue Sep 14, 2022
Merged
3 tasks
kegsay added a commit to matrix-org/matrix-react-sdk that referenced this issue Sep 15, 2022
@kegsay
bugfix: fix in-reply-to previews not disappearing when swapping rooms (…
a3133fa 
…#9278)

* bugfix: fix in-reply-to previews not disappearing when swapping rooms

This was caused by the fix for another issue:
  - element-hq/element-web#21462

Both bugs are now fixed with cypress regression tests.

* Linting

* Ensure the reply-to reappears when you click back

* Add jest test for replyTo in RVS

* Linting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
A-Composer A-Replies reply A-Timeline O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Maintain reply-to-event when clicking room permalink matrix-org/matrix-react-sdk
2 participants
@t3chguy @aaronraimist