Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We still show the "add phone number" UX in user settings even if no identity server is in use #21708

Open
lampholder opened this issue Apr 7, 2022 · 1 comment
Open

We still show the "add phone number" UX in user settings even if no identity server is in use #21708

lampholder opened this issue Apr 7, 2022 · 1 comment
Labels
A-Identity-Server O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@lampholder
Copy link
Member

Steps to reproduce

  1. Disable your connection to the identity server
  2. Try and add a phone number
  3. Observe: a 500 error (after you've been told that the SMS has been sent)

Outcome

What did you expect?

  • The add phone number UX should be suppressed when there is no identity server.
  • Really, the "SMS has been sent" confirmation should be conditional on a 200 from the identity server send SMS request, not just included as part of the local echo.

What happened instead?

500

Operating system

All of them

Browser information

Firefox Nightly

URL for webapp

app.element.io

Application version

Latest

Homeserver

matrix.org

Will you send logs?

No
@dbkr dbkr added S-Minor Impairs non-critical functionality or suitable workarounds exist A-Identity-Server O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Apr 7, 2022
@t3chguy
Copy link
Member

t3chguy commented Oct 14, 2022

Related element-hq/element-meta#766

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Identity-Server O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dbkr @lampholder @t3chguy