Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error messages for when features are disabled on a users HS #766

Open
ninchuka opened this issue Oct 14, 2022 · 2 comments
Open

Better error messages for when features are disabled on a users HS #766

ninchuka opened this issue Oct 14, 2022 · 2 comments
Labels
O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement

Comments

@ninchuka
Copy link

Your use case

What would you like to do?

have more descriptive errors on why something is not working, such as adding a phone number in element on matrix.org

Why would you like to do it?

to reduce the amount of people asking about why something isnt working with a cryptic error message

How would you like to achieve it?

have a way for the app to know if something is disabled on the HS and to share that to the user easily when they try to use such feature thats turned off

Have you considered any alternatives?

No response

Additional context

No response

Are you willing to provide a PR?

No

@aaronraimist
Copy link

Example: Currently users see

Limit exceeded for this country

when trying to attached a phone number to a matrix.org account which doesn't really explain the situation https://matrix.to/#/!YTvKGNlinIzlkMTVRl:matrix.org/$AtnUGtmHXWiMuAtK3hvquiP90PPJ87y9qAI-ZEaRQ7U?via=matrix.org&via=privacytools.io&via=mozilla.org

https://github.com/matrix-org/sydent/blob/cc9d46d9c2502c7ea62218eb617e9785282ebf2f/sydent/http/servlets/msisdnservlet.py#L125

@csharper2010
Copy link

I get error when trying to add phone number even if identity server vector.im is set up:

MatrixError: [500] Internal Server Error (https://matrix-client.matrix.org/_matrix/client/r0/account/3pid/msisdn/requestToken) (Status 500)

@pmaier1 pmaier1 added O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist P3 labels Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement
Projects
None yet
Development

No branches or pull requests

5 participants