Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keyshare-on-invite should start with most-recently-used sessions #23778

Closed
richvdh opened this issue Nov 16, 2022 · 2 comments
Closed

Keyshare-on-invite should start with most-recently-used sessions #23778

richvdh opened this issue Nov 16, 2022 · 2 comments
Labels
A-E2EE A-Invite O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Enhancement Z-Legacy-Crypto Issues affecting the legacy crypto stack Z-UISI Unable to decrypt errors

Comments

@richvdh
Copy link
Member

richvdh commented Nov 16, 2022 •
edited by pmaier1
Loading

When inviting a user to a room, we share megolm keys for the room history. This can result in thousands of to-device events, which can take a significant amount of time to be sent and received, which means it can take a while before the recipient can decrypt the most recent events, leading to #22999.

If we sent out the most-recently-used sessions first, that would improve the experience.
@richvdh richvdh added S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Enhancement Z-UISI Unable to decrypt errors O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience Team: Crypto labels Nov 16, 2022
@richvdh richvdh mentioned this issue Nov 16, 2022
Open
@richvdh
Copy link
Member Author

richvdh commented Nov 16, 2022 •
edited
Loading

It's likely we'll "fix" this by migrating to the rust crypto-sdk (not that it implements this yet: #26867)

@richvdh richvdh mentioned this issue Nov 16, 2022
Open
68 tasks
This was referenced Nov 18, 2022
Open
Closed
@richvdh richvdh mentioned this issue Jan 9, 2023
Closed
@pmaier1 pmaier1 mentioned this issue May 22, 2023
Open
4 tasks
@richvdh richvdh added Z-Legacy-Crypto Issues affecting the legacy crypto stack and removed Team: Crypto labels Nov 7, 2023
@richvdh richvdh mentioned this issue Jan 12, 2024
Open
@BillCarsonFr
Copy link
Member

Closing as this concern the old implementation that we don't support in the rust stack.
The future MSC and implementation will have requirement to be faster

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-E2EE A-Invite O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Enhancement Z-Legacy-Crypto Issues affecting the legacy crypto stack Z-UISI Unable to decrypt errors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@MadLittleMods @Johennes @richvdh @BillCarsonFr @robintown