Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

> 5.500 sync requests after login #24167

Closed
weeman1337 opened this issue Jan 5, 2023 · 1 comment · Fixed by matrix-org/matrix-js-sdk#3029
Closed

> 5.500 sync requests after login #24167

weeman1337 opened this issue Jan 5, 2023 · 1 comment · Fixed by matrix-org/matrix-js-sdk#3029
Labels
T-Defect

Comments

@weeman1337
Copy link
Contributor

weeman1337 commented Jan 5, 2023 •
edited

Steps to reproduce

  1. Have an active session (~ 150 rooms / DMs) and the client open
  2. Login in with another app/browser
  3. Wait for initial loader to disappear
  4. Choose verify with other session
  5. Verify
  6. Look at the network log

Outcome

What did you expect?

A number of initial requests. Then „normal sync requests“.

What happened instead?

Large number of requests happening in a short time.
Had to stop after 5.666 requests because the log crashed.
Requests continue after reloading.

From the logs I can read, that the existing session is sending key requests

Sending logs from both sessions

Operating system

Ubuntu 22.04.1 LTS

Browser information

Firefox 108.0.1

URL for webapp

https://app.element.io/

Application version

Version von Element: 1.11.17 Version von Olm: 3.2.12

Homeserver

element.ems.host

Will you send logs?

Yes
@weeman1337 weeman1337 mentioned this issue Jan 5, 2023
Merged
3 tasks
@richvdh
Copy link
Member

richvdh commented Jan 9, 2023

This was caused by matrix-org/matrix-js-sdk#2921, and fixed by matrix-org/matrix-js-sdk#3029. It's worth noting that, by the time you've been bitten by that issue, it has already done its damage, and the affected client has already re-queued hundreds of thousands of key-share requests; upgrading to a version of element-web with the fix won't do much - you just have to wait for all the requests to work their way through the system :(.

@odelcroi odelcroi mentioned this issue Jan 10, 2023
Closed
@richvdh richvdh mentioned this issue Jan 10, 2023
Closed
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this issue Jan 19, 2023
@su-ex
Merge tag 'v23.1.0' into sc
e6c127a 
* Remove extensible events v1 field population on legacy events ([\matrix-org#3040](matrix-org#3040)).
* Improve hasUserReadEvent and getUserReadUpTo realibility with threads ([\matrix-org#3031](matrix-org#3031)). Fixes element-hq/element-web#24164.
* Remove video track when muting video ([\matrix-org#3028](matrix-org#3028)). Fixes element-hq/element-call#209.
* Make poll start event type available (PSG-962) ([\matrix-org#3034](matrix-org#3034)).
* Add alt event type matching in Relations model ([\matrix-org#3018](matrix-org#3018)).
* Remove usage of v1 Identity Server API ([\matrix-org#3003](matrix-org#3003)).
* Add `device_id` to `/account/whoami` types ([\matrix-org#3005](matrix-org#3005)).
* Implement MSC3912: Relation-based redactions ([\matrix-org#2954](matrix-org#2954)).
* Introduce a mechanism for using the rust-crypto-sdk ([\matrix-org#2969](matrix-org#2969)).
* Support MSC3391: Account data deletion ([\matrix-org#2967](matrix-org#2967)).
* Fix threaded cache receipt when event holds multiple receipts ([\matrix-org#3026](matrix-org#3026)).
* Fix false key requests after verifying new device ([\matrix-org#3029](matrix-org#3029)). Fixes element-hq/element-web#24167 and element-hq/element-web#23333.
* Avoid triggering decryption errors when decrypting redacted events ([\matrix-org#3004](matrix-org#3004)). Fixes element-hq/element-web#24084.
* bugfix: upload OTKs in sliding sync mode ([\matrix-org#3008](matrix-org#3008)).
* Apply edits discovered from sync after thread is initialised ([\matrix-org#3002](matrix-org#3002)). Fixes element-hq/element-web#23921.
* Sliding sync: Fix issue where no unsubs are sent when switching rooms ([\matrix-org#2991](matrix-org#2991)).
* Threads are missing from the timeline ([\matrix-org#2996](matrix-org#2996)). Fixes element-hq/element-web#24036.
* Close all streams when a call ends ([\matrix-org#2992](matrix-org#2992)). Fixes element-hq/element-call#742.
* Resume to-device message queue after resumed sync ([\matrix-org#2920](matrix-org#2920)). Fixes matrix-org/element-web-rageshakes#17170.
* Fix browser entrypoint ([\matrix-org#3051](matrix-org#3051)). Fixes matrix-org#3013.
* Fix failure to start in firefox private browser ([\matrix-org#3058](matrix-org#3058)). Fixes element-hq/element-web#24216.
* Correctly handle limited sync responses by resetting the thread timeline ([\matrix-org#3056](matrix-org#3056)). Fixes element-hq/element-web#23952.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix false key requests after verifying new device matrix-org/matrix-js-sdk
2 participants
@richvdh @weeman1337