Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to date feature cannot be enabled #24362

Open
robintown opened this issue Jan 29, 2023 · 0 comments
Open

Jump to date feature cannot be enabled #24362

robintown opened this issue Jan 29, 2023 · 0 comments
Labels
A-Jump-To-Date Jump to date headers or slash command O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Labs

Comments

@robintown
Copy link
Member

robintown commented Jan 29, 2023

Steps to reproduce

  1. Use a homeserver with stable support for MSC3030
  2. Open labs

Outcome

What did you expect?

To see the toggle switch for the jump to date labs feature

What happened instead?

It's hidden, because the app still only recognizes MSC3030 as an unstable feature

Workaround

(this no longer works because feature toggles that are "disabled" can't be enabled or disabled)

Enable jump to date manually:

await mxSettingsStore.setValue("feature_jump_to_date", null, "device", true)

Disable jump to date manually:

await mxSettingsStore.setValue("feature_jump_to_date", null, "device", false)

Operating system

NixOS unstable

Browser information

Firefox 108.0.2

URL for webapp

develop.element.io

Application version

Element version: bd26775-react-222f8a919dd9-js-ef51ee28fda9 Olm version: 3.2.12

Homeserver

Synapse 1.75.0

Will you send logs?

No

@florianduros florianduros added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Jan 30, 2023
@MadLittleMods MadLittleMods added the A-Jump-To-Date Jump to date headers or slash command label Feb 2, 2023
MadLittleMods added a commit to matrix-org/matrix-react-sdk that referenced this issue Mar 17, 2023
…upported on a homeserver (#10398)

Add stable unstable version (`org.matrix.msc3030.stable`) for jump to date [before `v1.6` is fully supported on a homeserver](matrix-org/synapse#15089).

Related to element-hq/element-web#24362 but does not solve immediately because Synapse does not supply `org.matrix.msc3030.stable` yet

Also refactored `ServerSupportUnstableFeatureController` to support multiple feature groups where any one of them will enable the setting. All features in a feature group are required. This way having either `org.matrix.msc3030` or `org.matrix.msc3030.stable` will enable the jump to date feature flag with a config of `[["org.matrix.msc3030"], ["org.matrix.msc3030.stable"]]`
toomore pushed a commit to moda-gov-tw/matrix-org.matrix-react-sdk that referenced this issue Apr 6, 2023
…upported on a homeserver (#10398)

Add stable unstable version (`org.matrix.msc3030.stable`) for jump to date [before `v1.6` is fully supported on a homeserver](matrix-org/synapse#15089).

Related to element-hq/element-web#24362 but does not solve immediately because Synapse does not supply `org.matrix.msc3030.stable` yet

Also refactored `ServerSupportUnstableFeatureController` to support multiple feature groups where any one of them will enable the setting. All features in a feature group are required. This way having either `org.matrix.msc3030` or `org.matrix.msc3030.stable` will enable the jump to date feature flag with a config of `[["org.matrix.msc3030"], ["org.matrix.msc3030.stable"]]`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Jump-To-Date Jump to date headers or slash command O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Labs
Projects
None yet
4 participants