Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace hard-coded font-weight values with CSS custom properties #25073

Closed
luixxiul opened this issue Apr 9, 2023 · 1 comment
Closed

Replace hard-coded font-weight values with CSS custom properties #25073

luixxiul opened this issue Apr 9, 2023 · 1 comment
Labels
A-Developer-Experience O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement

Comments

@luixxiul
Copy link

luixxiul commented Apr 9, 2023 •
edited
Loading

Your use case

What would you like to do?

Replace hard-coded font-weight values with CSS custom properties on _font-weights.pcss. Currently there is just $font-semi-weight: 600 on the file.

Why would you like to do it?

Because the style guide suggests you to use a variable for a font property. CSS custom properties have been implemented for other properties such as spacing and font-size, and they should be specified for font-weight as well.

How would you like to achieve it?

Add variables for font-weight 400, 500, 700, 900, etc.

Have you considered any alternatives?

No response

Additional context

No response
@luixxiul luixxiul mentioned this issue Apr 9, 2023
Merged
3 tasks
@weeman1337 weeman1337 added A-Developer-Experience S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely labels Apr 19, 2023
@Johennes
Copy link
Contributor

Closing this as not planned because we'll be governing fonts via Compound.

@Johennes Johennes closed this as not planned Won't fix, can't repro, duplicate, stale Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Developer-Experience O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Johennes @luixxiul @weeman1337