Replace Sass variables with custom properties on _font-weights.pcss
#10554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Z-Community-PR
luixxiul
changed the title
_font-weights.pcss_font-weights.pcss
luixxiul
changed the title
_font-weights.pcss_font-weights.pcss
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
luixxiul
changed the title
_font-weights.pcss--font-semi-bold on _font-weights.pcss
luixxiul
changed the title
--font-semi-bold on _font-weights.pcss_font-weights.pcss
|
Fixing the conflict.. |
auto-merge was automatically disabled
April 21, 2023 13:17
Head branch was pushed to by a user without write access
richvdh
requested changes
Apr 21, 2023
richvdh
reviewed
Apr 21, 2023
| @@ -27,12 +27,10 @@ $SpaceRoomViewInnerWidth: 428px; | |||
| font-weight: $font-semi-bold; | |||
There was a problem hiding this comment.
Right, addressed with 9e30d1b.
|
This time it finally should be ok.. |
richvdh
approved these changes
Apr 21, 2023
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For element-hq/element-web#21656 and element-hq/element-web#25073
This PR intends to replace existing Sass variables on
_font-weights.pcssand declarations with hard-coded value (font-weight: 600) with CSS custom properties, based on the style guide.Currently there are two custom properties on
_font-weights.pcss(--font-normaland--font-semi-bold). Custom properties for the other weight values are yet to be implemented.The PR is based on the assumption that
font-weight: 600is always equal tofont-weight: var(--font-semi-bold). Please correct me if I am wrong.type: task
Signed-off-by: Suguru Hirahara luixxiul@users.noreply.github.com
Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.