Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sessions manager's inline action buttons are not aligned #25545

Closed
luixxiul opened this issue Jun 9, 2023 · 2 comments · Fixed by matrix-org/matrix-react-sdk#11279
Closed

Sessions manager's inline action buttons are not aligned #25545

luixxiul opened this issue Jun 9, 2023 · 2 comments · Fixed by matrix-org/matrix-react-sdk#11279
Assignees
@t3chguy
Labels
Help Wanted Extra attention is needed O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@luixxiul
Copy link

luixxiul commented Jun 9, 2023

Steps to reproduce

  1. Open Sessions user settings tab
  2. Check Sessions on the filtered device list header

Outcome

What did you expect?

The inline buttons should be aligned to the center

1

What happened instead?

They are aligned to the top

0

Operating system

No response

Browser information

No response

URL for webapp

develop.element.io

Application version

No response

Homeserver

No response

Will you send logs?

No
@luixxiul luixxiul mentioned this issue Jun 9, 2023
Closed
3 tasks
@luixxiul
Copy link
Author

luixxiul commented Jun 9, 2023

Regressed by https://github.com/matrix-org/matrix-react-sdk/pull/10972/files#diff-0c6139dd8fb5707cd9ac7874d270d5a8df772679956e2f6e43f11a45494cf3e2R36-R39 (matrix-org/matrix-react-sdk#10972)

@luixxiul
Copy link
Author

luixxiul commented Jun 9, 2023 •
edited
Loading

For a committer to fix the issue: it is recommended to create a dedicated component for buttons, rather than adding CSS style rules which make them even more complex

@luixxiul luixxiul mentioned this issue Jun 13, 2023
Closed
@luixxiul luixxiul changed the title Inline buttons on FilteredDeviceListHeader on Sessions user settings tab should be aligned to the center Sessions manager action button misaligned Inline buttons on FilteredDeviceListHeader on Sessions user settings tab should be aligned to the center Jun 13, 2023
@luixxiul luixxiul changed the title Sessions manager action button misaligned Inline buttons on FilteredDeviceListHeader on Sessions user settings tab should be aligned to the center Sessions manager's inline action buttons are not aligned Jun 13, 2023
@kittykat kittykat added S-Minor Impairs non-critical functionality or suitable workarounds exist Help Wanted Extra attention is needed O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Jun 15, 2023
@t3chguy t3chguy self-assigned this Jul 17, 2023
@t3chguy t3chguy mentioned this issue Jul 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
Help Wanted Extra attention is needed O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Milestone
No milestone
3 participants
@kittykat @t3chguy @luixxiul