Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to do retries on key-sharing messages #2568

Closed
richvdh opened this issue Nov 11, 2016 · 0 comments · Fixed by matrix-org/matrix-js-sdk#295
Closed

Need to do retries on key-sharing messages #2568

richvdh opened this issue Nov 11, 2016 · 0 comments · Fixed by matrix-org/matrix-js-sdk#295
Labels
A-E2EE T-Defect

Comments

@richvdh
Copy link
Member

richvdh commented Nov 11, 2016

If there is an error sending the key-sharing message, then the room message is marked as unsent. The problem is that on retry, we don't attempt to resend the key-sharing message.
richvdh added a commit to matrix-org/matrix-js-sdk that referenced this issue Nov 16, 2016
@richvdh
Check devices to share keys with on each send
769a0cb 
Instead of trying to maintain a list of devices we need to share with, just
check all the devices for all the users on each send.

This should fix element-hq/element-web#2568, and
generally mean we're less likely to get out of sync.
@richvdh richvdh mentioned this issue Nov 16, 2016
Merged
@richvdh richvdh closed this as completed Nov 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-E2EE T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

E2E: Check devices to share keys with on each send matrix-org/matrix-js-sdk
1 participant
@richvdh