Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows shortcut #2775

Closed
RadialAdmin opened this issue Dec 20, 2016 · 2 comments
Closed

Windows shortcut #2775

RadialAdmin opened this issue Dec 20, 2016 · 2 comments
Labels
A-Electron P1 T-Defect

Comments

@RadialAdmin
Copy link

Windows shortcut linked to C:\Users\User\AppData\Local\riot\Riot.exe instead C:\Users\User\AppData\Local\riot\app-0.9.2\Riot.exe
@ara4n
Copy link
Member

ara4n commented Dec 24, 2016

fixed by 4de042b

Not entirely sure why this worked, but \riot has an Update.exe and \riot\app-0.9.x does too. I just told it to run the one in the subfolder in the hope that it might the link to the right place, rather than the broken parent folder location.

@RadialAdmin thanks for the report!

@ara4n ara4n closed this as completed Dec 24, 2016
@ara4n
Copy link
Member

ara4n commented Dec 24, 2016

(this was released in 0.9.5 an hour or so ago)

dbkr added a commit that referenced this issue Jan 11, 2017
@dbkr
Hopefully fix Windows shortcuts
06718c5 
 * Revert 79d1643
   as it seems to break shortcuts altogether
 * Update electron-builder (and add the squirrel windows package
   that the newer version now requires: it's been split out). This
   uses a newer version of squirrel which has some fixes for
   shortcuts.

I'm unsure exactly what was going wrong originally in
#2775 but #79d1643
seems to break shortcut creation as far as I can see.
@dbkr dbkr mentioned this issue Jan 11, 2017
Merged
Half-Shot pushed a commit to Half-Shot/riot-web that referenced this issue Feb 9, 2017
@dbkr @Half-Shot
Hopefully fix Windows shortcuts
5ed64a7 
 * Revert element-hq@79d1643
   as it seems to break shortcuts altogether
 * Update electron-builder (and add the squirrel windows package
   that the newer version now requires: it's been split out). This
   uses a newer version of squirrel which has some fixes for
   shortcuts.

I'm unsure exactly what was going wrong originally in
element-hq#2775 but #79d1643
seems to break shortcut creation as far as I can see.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Electron P1 T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ara4n @RadialAdmin