Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

one-time-key upload/claim is racy #3868

Closed
Tracked by #2996
richvdh opened this issue May 9, 2017 · 2 comments
Closed
Tracked by #2996

one-time-key upload/claim is racy #3868

richvdh opened this issue May 9, 2017 · 2 comments
Labels
A-E2EE P2 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@richvdh
Copy link
Member

richvdh commented May 9, 2017

  • Alice tries to upload one-time-key, but doesn't get response
  • Bob claims the key
  • Alice uploads the key again
  • Charlie claims the key

Only one of Bob or Charlie can use the key to talk to Alice.
@richvdh richvdh mentioned this issue May 9, 2017
Closed
25 tasks
richvdh added a commit to matrix-org/synapse that referenced this issue May 9, 2017
@richvdh
Do some logging when one-time-keys get claimed
de042b3 
might help us figure out if element-hq/element-web#3868
has happened.
@lampholder lampholder added T-Defect P1 A-E2EE S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels May 11, 2017
@richvdh
Copy link
Member Author

richvdh commented Jun 6, 2017

this is super-unlikely, as it requires Bob to claim the key in the window between Alice's attempts to upload the key. Probably not p1 or major.

@richvdh richvdh mentioned this issue Jun 6, 2017
Open
@ara4n ara4n added P2 and removed P1 labels Sep 30, 2018
@ara4n ara4n mentioned this issue Sep 30, 2018
Closed
@ShadowJonathan ShadowJonathan mentioned this issue Jan 22, 2022
Closed
@turt2live turt2live mentioned this issue Jun 14, 2022
Open
@turt2live
Copy link
Member

Closing in favour of matrix-org/matrix-spec#1124

@turt2live turt2live closed this as not planned Won't fix, can't repro, duplicate, stale Jun 14, 2022
@kegsay kegsay mentioned this issue Apr 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-E2EE P2 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@turt2live @ara4n @richvdh @lampholder