MXID disambiguation stays visible indefinitely long

[rkfg]

Description

If a user sets a name that matches other user's name the MXID disambiguation part is appended to it. However, if the other user leaves or changes their name the disambiguation part isn't getting away. That could pose problems, for instance, if a user tried Matrix first using matrix.org and then switched to their own homeserver using the same nickname. It's hard to get rid of that (@username:homeserver.org) part for everyone. It's not even consistent, some users/accounts see it and some don't: I don't see it from the work account and it's present when I log in from home using another account.

Steps to reproduce

• join a room using a matrix.org account with username test
• join the same room using another homeserver (say homeserver.org) and also rename to test
• the second user is now visible as test (@username:homeserver.org)
• switch to the first user and leave the room

The second user will still be test (@username:homeserver.org) even after refreshing the page/restarting the client. I expect the disambiguation to be resolved automatically so there are no MXID parts appended anywhere or there should be a way to refresh the data manually. Also, I think MXID should be appended to both ambiguous users, not just to the latter.

Version information

• Platform: web/desktop (happens in both)
• Browser: Chrome 61.0.3163.39
• OS: Debian testing amd64
• URL: riot.im/develop

[t3chguy]

It is appended to all ambiguous users:

[rkfg]

Hmm? Weird, I renamed from rkfg2 to rkfg [work] and this is what it looks like at riot.im/develop:

Same after refreshing the tab.

[uhoreg]

possible related: #2926, #468

[HarHarLinks]

1. invite Alice @alice:example.org
2. invite Alice @bob:example.org
3. disinvite Alice @alice:example.org
4. Disambiguation is shown for @bob:example.org even though there is no ambiguous member anymore

you could argue that this makes sense so you don't confuse them, but then element should do disambiguation based on all historic display names