Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redacting a widget add state event does not refresh the app bar #4915

Open
turt2live opened this issue Aug 28, 2017 · 2 comments
Open

Redacting a widget add state event does not refresh the app bar #4915

turt2live opened this issue Aug 28, 2017 · 2 comments
Labels
A-Redaction P2 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@turt2live
Copy link
Member

Description

It updates after you switch away and back to the room.

Steps to reproduce

  • Add a widget
  • Redact the "X widget added by Z" event
  • Note that the app bar does not update

The widget should just disappear, surely (considering it does this when navigating away and back again).

Log: not sent

Version information

  • Platform: web (in-browser)
  • Browser: Chrome 60
  • OS: Windows 10
  • URL: riot.im/develop
@turt2live turt2live mentioned this issue Aug 28, 2017
Open
@t3chguy
Copy link
Member

t3chguy commented Aug 28, 2017

This is because RoomState.events does not fire when a state event changes due to being redacted locally, I'd argue it should so maybe a js-sdk issue.

@lampholder lampholder added T-Defect S-Minor Impairs non-critical functionality or suitable workarounds exist P2 labels Sep 5, 2017
@lampholder
Copy link
Member

Does the RoomState.events not firing have other user-affecting consequences at the moment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Redaction P2 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jryans @turt2live @lampholder @t3chguy