Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redacting the removal of a widget does not restore it #4916

Open
turt2live opened this issue Aug 28, 2017 · 3 comments
Open

Redacting the removal of a widget does not restore it #4916

turt2live opened this issue Aug 28, 2017 · 3 comments
Labels
A-Redaction A-Widgets P2 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@turt2live
Copy link
Member

Description

Unlike #4915, navigating away and back again does not restore the widget.

Steps to reproduce

  • Add a widget
  • Remove the widget (with the X)
  • Redact the "X widget removed by Z" event

The widget should be restored (immediately refreshing the app bar as well).

Log: not sent

Version information

  • Platform: web (in-browser)
  • Browser: Chrome 60
  • OS: Windows 10
  • URL: riot.im/develop
@t3chguy
Copy link
Member

t3chguy commented Aug 28, 2017

not sure how this would work,

when I redact the removal and look at the room state
working widget config is in prev_content, and I can see that the state is redacted so I could apply prev_content, but then if I redact the addition of the widget which occured right before that, nothing changes and the widget would still be alive :L

@turt2live
Copy link
Member Author

@lampholder this is going to sound odd, but I'd argue this is lower priority. It's unlikely (hopefully) that someone is going to redact the removal of a widget. I only did because I was curious as to what would happen

@lampholder
Copy link
Member

Heh, I agree the specific problem probably isn't P1 - my P1 was just a reflection that the interplay between widgets and events really needs to be thought about properly before we dig too deep a hole.

You're right though P1 probably is a bit strong :)

@lampholder lampholder added P2 S-Minor Impairs non-critical functionality or suitable workarounds exist and removed P1 labels Sep 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Redaction A-Widgets P2 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Development

No branches or pull requests

4 participants