-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Long homeserver domain names and internationalisation to longer languages (like French) break "Sign in with" box #5767
Comments
Quick fix: truncate with ellipsis. Controversial longer fix: bring back the enhanced user name button that I mooted at some point in the past with the @ and the domain baked into the username field (I think people didn't like it):
|
This is a common problem all around Riot and there are several related issues with the same symptoms (i.e. text does not fit into combobox). It seems like a generic solution is needed, so probably the ellipsis one is the best (although certainly it is possible to additionally special case this one) |
ellipsising ftw for now as quick fix, although it obviously opens the door to nasty phishing attacks if matthew.modular.im gets truncated so matthew.modular.im.evil.com could be injected too. should be fixed properly in redesign. |
The whole dropdown can probably be removed when element-hq/element-meta#1582 is implemented |
Conclusion: we're going to use an ellipsis and punt the remainder to the redesign (#7586) |
This was actually fixed long ago by #6244 |
Description
Riot's login page has a "Sign in with" box, which lists the options to authenticate with. The text overflows out of the box when the domain name is too long.
Steps to reproduce
Version information
Web, 0.13.2
Present on latest versions of Chromium and Firefox.
The text was updated successfully, but these errors were encountered: