Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't delete quote blocks with delete key in rich text mode #7676

Closed
nadonomy opened this issue Nov 9, 2018 · 6 comments
Closed

Can't delete quote blocks with delete key in rich text mode #7676

nadonomy opened this issue Nov 9, 2018 · 6 comments
Labels
P1 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@nadonomy
Copy link
Contributor

nadonomy commented Nov 9, 2018 •
edited
Loading

But oddly, hitting return works:

cantdelete
@t3chguy
Copy link
Member

t3chguy commented Nov 9, 2018

might need more info to know what you mean

Which delete button?

@nadonomy
Copy link
Contributor Author

nadonomy commented Nov 9, 2018

Just updated with a gif illustrating keyboard keystrokes. Will update the title to clarify too.

@nadonomy nadonomy changed the title Delete button doesn't delete quoted messages in the composer Delete key doesn't delete quoted messages in the composer Nov 9, 2018
@t3chguy
Copy link
Member

t3chguy commented Nov 9, 2018

I have a feeling this might be a regression as I'm 99% this used to work

@lampholder lampholder changed the title Delete key doesn't delete quoted messages in the composer Can't delete the quote block with the delete key (in rich text mode) Nov 15, 2018
@lampholder
Copy link
Member

I have a feeling this might be a regression as I'm 99% this used to work

Confirmed this is a regression - this worked pre-slate.

@lampholder lampholder added T-Defect P1 S-Minor Impairs non-critical functionality or suitable workarounds exist type:composer labels Nov 15, 2018
@t3chguy
Copy link
Member

t3chguy commented Nov 15, 2018

I meant a since-slate regression, as I think (not 100% sure) this worked in my original implementation

@nadonomy nadonomy changed the title Can't delete the quote block with the delete key (in rich text mode) Can't delete quote blocks with delete key in rich text mode Nov 27, 2018
@nadonomy nadonomy mentioned this issue Jan 4, 2019
Closed
@t3chguy
Copy link
Member

t3chguy commented Mar 24, 2020

We no longer have this rich text mode in the new composer

@t3chguy t3chguy closed this as completed Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P1 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lampholder @t3chguy @nadonomy