Room padlock is green immediately after enabling e2e on a room #8708
Comments
|
Hmm, I wasn't able to reproduce this, but I wonder if there's an edge case where a user (whose devices you have verified) adds a device in between their being invited and you clicking on their device list? |
lampholder
added
T-Defect
P1
S-Major
|
This was done on a closed-network homeserver. I invite a user to a chat, they accept, then I enable e2e, and instantly the padlock goes green (even though I've verified none of their devices, and they certainly haven't added new devices in the meantime). I've reproduced it 4 times with different people. That said, I'm having a hard time reproducing it again this morning. I'm wondering if the closed-network speed is causing a race that isn't normally seen over the internet. |
|
Just ran into this myself on open federation between amorgan.xyz and matrix.org. Have sent logs. |
|
Also interestingly Riot has now marked it as a public room (not a DM). |
|
Just triggered this again this morning. Switched long-running chat with lots of devices (all unverified) over to e2e, and room padlock turned green until I navigated away/back to it |
|
The room decoration logic is now different with cross-signing, so this issue is probably no longer relevant. |
su-ex
added a commit
to SchildiChat/element-web
that referenced
this issue
Jun 7, 2022
* Make Lao translation available ([\element-hq#22358](element-hq#22358)). Fixes element-hq#22327. * Option to disable hardware acceleration on Element Desktop ([\element-hq#22295](element-hq#22295)). Contributed by @novocaine. * Configure custom home.html via `.well-known/matrix/client["io.element.embedded_pages"]["home_url"]` for all your element-web/desktop users ([\element-hq#7790](matrix-org/matrix-react-sdk#7790)). Contributed by @johannes-krude. * Live location sharing - open location in OpenStreetMap ([\element-hq#8695](matrix-org/matrix-react-sdk#8695)). Contributed by @kerryarchibald. * Show a dialog when Jitsi encounters an error ([\element-hq#8701](matrix-org/matrix-react-sdk#8701)). Fixes element-hq#22284. * Add support for setting the `avatar_url` of widgets by integration managers. ([\element-hq#8550](matrix-org/matrix-react-sdk#8550)). Contributed by @Fox32. * Add an option to ignore (block) a user when reporting their events ([\element-hq#8471](matrix-org/matrix-react-sdk#8471)). * Add the option to disable hardware acceleration ([\element-hq#8655](matrix-org/matrix-react-sdk#8655)). Contributed by @novocaine. * Slightly better presentation of read receipts to screen reader users ([\element-hq#8662](matrix-org/matrix-react-sdk#8662)). Fixes element-hq#22293. Contributed by @pvagner. * Add jump to related event context menu item ([\element-hq#6775](matrix-org/matrix-react-sdk#6775)). Fixes element-hq#19883. * Add public room directory hook ([\element-hq#8626](matrix-org/matrix-react-sdk#8626)). * Stop Jitsi if we time out while connecting to a video room ([\element-hq#22301](element-hq#22301)). Fixes element-hq#22283. * Remove inline margin from UTD error message inside a reply tile on ThreadView ([\element-hq#8708](matrix-org/matrix-react-sdk#8708)). Fixes element-hq#22376. Contributed by @luixxiul. * Move unread notification dots of the threads list to the expected position ([\element-hq#8700](matrix-org/matrix-react-sdk#8700)). Fixes element-hq#22350. Contributed by @luixxiul. * Prevent overflow of grid items on a bubble with UTD generally ([\element-hq#8697](matrix-org/matrix-react-sdk#8697)). Contributed by @luixxiul. * Create 'Unable To Decrypt' grid layout for hidden events on a bubble layout ([\element-hq#8704](matrix-org/matrix-react-sdk#8704)). Fixes element-hq#22365. Contributed by @luixxiul. * Fix - AccessibleButton does not set disabled attribute ([\element-hq#8682](matrix-org/matrix-react-sdk#8682)). Contributed by @kerryarchibald. * Fix font not resetting when logging out ([\element-hq#8670](matrix-org/matrix-react-sdk#8670)). Fixes element-hq#17228. * Fix local aliases section of room settings not working for some homeservers (ie ([\element-hq#8698](matrix-org/matrix-react-sdk#8698)). Fixes element-hq#22337. * Align EventTile_line with display name on message bubble ([\element-hq#8692](matrix-org/matrix-react-sdk#8692)). Fixes element-hq#22343. Contributed by @luixxiul. * Convert references to direct chat -> direct message ([\element-hq#8694](matrix-org/matrix-react-sdk#8694)). Contributed by @novocaine. * Improve combining diacritics for U+20D0 to U+20F0 in Chrome ([\element-hq#8687](matrix-org/matrix-react-sdk#8687)). * Make the empty thread panel fill BaseCard ([\element-hq#8690](matrix-org/matrix-react-sdk#8690)). Fixes element-hq#22338. Contributed by @luixxiul. * Fix edge case around composer handling gendered facepalm emoji ([\element-hq#8686](matrix-org/matrix-react-sdk#8686)). * Fix a grid blowout due to nowrap displayName on a bubble with UTD ([\element-hq#8688](matrix-org/matrix-react-sdk#8688)). Fixes element-hq#21914. Contributed by @luixxiul. * Apply the same max-width to image tile on the thread timeline as message bubble ([\element-hq#8669](matrix-org/matrix-react-sdk#8669)). Fixes element-hq#22313. Contributed by @luixxiul. * Fix dropdown button size for picture-in-picture CallView ([\element-hq#8680](matrix-org/matrix-react-sdk#8680)). Fixes element-hq#22316. Contributed by @luixxiul. * Live location sharing - fix square border for image-less avatar (PSF-1052) ([\element-hq#8679](matrix-org/matrix-react-sdk#8679)). Contributed by @kerryarchibald. * Stop connecting to a video room if the widget messaging disappears ([\element-hq#8660](matrix-org/matrix-react-sdk#8660)). * Fix file button and audio player overflowing from message bubble ([\element-hq#8666](matrix-org/matrix-react-sdk#8666)). Fixes element-hq#22308. Contributed by @luixxiul. * Don't show broken composer format bar when selection is whitespace ([\element-hq#8673](matrix-org/matrix-react-sdk#8673)). Fixes element-hq#10788. * Fix media upload http 413 handling ([\element-hq#8674](matrix-org/matrix-react-sdk#8674)). * Fix emoji picker for editing thread responses ([\element-hq#8671](matrix-org/matrix-react-sdk#8671)). Fixes matrix-org/element-web-rageshakes#13129. * Map attribution while sharing live location is now visible ([\element-hq#8621](matrix-org/matrix-react-sdk#8621)). Fixes element-hq#22236. Contributed by @weeman1337. * Fix info tile overlapping the time stamp on TimelineCard ([\element-hq#8639](matrix-org/matrix-react-sdk#8639)). Fixes element-hq#22256. Contributed by @luixxiul. * Fix position of wide images on IRC / modern layout ([\element-hq#8667](matrix-org/matrix-react-sdk#8667)). Fixes element-hq#22309. Contributed by @luixxiul. * Fix other user's displayName being wrapped on the bubble message layout ([\element-hq#8456](matrix-org/matrix-react-sdk#8456)). Fixes element-hq#22004. Contributed by @luixxiul. * Set spacing declarations to elements in mx_EventTile_mediaLine ([\element-hq#8665](matrix-org/matrix-react-sdk#8665)). Fixes element-hq#22307. Contributed by @luixxiul. * Fix wide image overflowing from the thumbnail container ([\element-hq#8663](matrix-org/matrix-react-sdk#8663)). Fixes element-hq#22303. Contributed by @luixxiul. * Fix styles of "Show all" link button on ReactionsRow ([\element-hq#8658](matrix-org/matrix-react-sdk#8658)). Fixes element-hq#22300. Contributed by @luixxiul. * Automatically log in after registration ([\element-hq#8654](matrix-org/matrix-react-sdk#8654)). Fixes element-hq#19305. Contributed by @justjanne. * Fix offline status in window title not working reliably ([\element-hq#8656](matrix-org/matrix-react-sdk#8656)). * Align input area with event body's first letter in a thread on IRC/modern layout ([\element-hq#8636](matrix-org/matrix-react-sdk#8636)). Fixes element-hq#22252. Contributed by @luixxiul. * Fix crash on null idp for SSO buttons ([\element-hq#8650](matrix-org/matrix-react-sdk#8650)). Contributed by @hughns. * Don't open the regular browser or our context menu on right-clicking the `Options` button in the message action bar ([\element-hq#8648](matrix-org/matrix-react-sdk#8648)). Fixes element-hq#22279. * Show notifications even when Element is focused ([\element-hq#8590](matrix-org/matrix-react-sdk#8590)). Contributed by @sumnerevans. * Remove padding from the buttons on edit message composer of a event tile on a thread ([\element-hq#8632](matrix-org/matrix-react-sdk#8632)). Contributed by @luixxiul. * ensure metaspace changes correctly notify listeners ([\element-hq#8611](matrix-org/matrix-react-sdk#8611)). Fixes element-hq#21006. Contributed by @justjanne. * Hide image banner on stickers, they have a tooltip already ([\element-hq#8641](matrix-org/matrix-react-sdk#8641)). Fixes element-hq#22244. * Adjust EditMessageComposer style declarations ([\element-hq#8631](matrix-org/matrix-react-sdk#8631)). Fixes element-hq#22231. Contributed by @luixxiul.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Start a chat with someone, enable e2e encryption, and the room padlock turns green even if you haven't verified any of the user's devices. The padlock will not turn red unless you load the user's list of devices by clicking their name in the user list, and then clicking on a different room and back again.
The text was updated successfully, but these errors were encountered: