Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle url encoding on matrix.to URIs #9149

Open
turt2live opened this issue Mar 13, 2019 · 2 comments
Open

Handle url encoding on matrix.to URIs #9149

turt2live opened this issue Mar 13, 2019 · 2 comments
Labels
A-Matrix.to P1 T-Enhancement Z-AccountResurrection Delight - cycle

Comments

@turt2live
Copy link
Member

Because the spec is highly likely to say we should : matrix-org/matrix-spec-proposals#1876
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Mar 26, 2019
@turt2live
Handle all the segments of a v3 event ID
d8edf2e 
They may contain slashes, so it is not suitable to just pull the first segment after the room ID. Instead, we just recompile the event ID from known source, assuming everything afterwards is an event ID.

Fixes element-hq/element-web#8315

This will need adapting to support element-hq/element-web#9149
@turt2live turt2live mentioned this issue Mar 26, 2019
Merged
@turt2live turt2live added the P1 label Mar 26, 2019
@turt2live
Copy link
Member Author

I've split performing encoding to its own task because it's a different unit of work: https://github.com/vector-im/riot-web/issues/9424

@turt2live turt2live changed the title Handle and perform url encoding on matrix.to URIs Handle url encoding on matrix.to URIs Apr 10, 2019
@turt2live turt2live mentioned this issue Apr 30, 2019
Closed
@turt2live turt2live added this to Raging Inferno 🔥🔥🔥 in Web App Team May 1, 2019
@turt2live turt2live moved this from Raging Inferno 🔥🔥🔥 to In Progress in Web App Team May 16, 2019
@turt2live turt2live self-assigned this May 16, 2019
@turt2live turt2live removed this from In Progress in Web App Team May 16, 2019
@turt2live turt2live removed their assignment Jul 11, 2019
This was referenced May 30, 2023
Open
Open
@bkil
Copy link

bkil commented May 30, 2023

Related #16875

@bkil bkil mentioned this issue May 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Matrix.to P1 T-Enhancement Z-AccountResurrection Delight - cycle
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@jryans @bkil @Johennes @turt2live @lampholder @daniellekirkwood