Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Add a widget" button broken in 1.0.5 #9266

Closed
turt2live opened this issue Mar 24, 2019 · 1 comment
Closed

"Add a widget" button broken in 1.0.5 #9266

turt2live opened this issue Mar 24, 2019 · 1 comment
Assignees
@turt2live
Labels
A-Widgets P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression X-Release-Blocker

Comments

@turt2live
Copy link
Member

This one:
image

bundle.js:61 Uncaught TypeError: Cannot read property 'connect' of undefined
    at Object._launchManageIntegrations (bundle.js:61)
    at Object.onClickAddWidget (bundle.js:61)
    at Object.o (bundle.js:39)
    at s (bundle.js:39)
    at Object.executeDispatchesInOrder (bundle.js:39)
    at f (bundle.js:23)
    at p (bundle.js:23)
    at Array.forEach (<anonymous>)
    at e.exports (bundle.js:61)
    at Object.processEventQueue (bundle.js:23)
    at bundle.js:63
    at Object.handleTopLevel [as _handleTopLevel] (bundle.js:63)
    at p (bundle.js:63)
    at u.perform (bundle.js:30)
    at Object.batchedUpdates (bundle.js:61)
    at Object.batchedUpdates (bundle.js:23)
@turt2live turt2live self-assigned this Mar 24, 2019
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Mar 24, 2019
@turt2live
Fix typo preventing users from adding more widgets easily
1ba23d6 
Fixes element-hq/element-web#9266
@turt2live turt2live mentioned this issue Mar 24, 2019
Merged
@jryans jryans added X-Regression P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround A-Widgets X-Release-Blocker labels Mar 25, 2019
@jryans
Copy link
Collaborator

jryans commented Mar 25, 2019 •
edited

Looks like this regression was introduced by matrix-org/matrix-react-sdk#2777, and the regression was shipped in 1.0.5.

@jryans jryans added this to In Progress in Web App Team via automation Mar 25, 2019
@jryans jryans moved this from In Progress to In Test in Web App Team Mar 25, 2019
@turt2live turt2live moved this from In Test to Done in Web App Team Apr 1, 2019
su-ex added a commit to SchildiChat/element-web that referenced this issue Sep 28, 2022
@su-ex
Merge tag 'v1.11.6' into sc
32c4e33 
* Element Call video rooms ([\element-hq#9267](matrix-org/matrix-react-sdk#9267)).
* Device manager - rename session ([\element-hq#9282](matrix-org/matrix-react-sdk#9282)).
* Allow widgets to read related events ([\element-hq#9210](matrix-org/matrix-react-sdk#9210)). Contributed by @dhenneke.
* Device manager - logout of other session ([\element-hq#9280](matrix-org/matrix-react-sdk#9280)).
* Device manager - logout current session ([\element-hq#9275](matrix-org/matrix-react-sdk#9275)).
* Device manager - verify other devices ([\element-hq#9274](matrix-org/matrix-react-sdk#9274)).
* Allow integration managers to remove users ([\element-hq#9211](matrix-org/matrix-react-sdk#9211)).
* Device manager - add verify current session button ([\element-hq#9252](matrix-org/matrix-react-sdk#9252)).
* Add NotifPanel dot back. ([\#9242](matrix-org/matrix-react-sdk#9242)). Fixes element-hq#17641.
* Implement MSC3575: Sliding Sync ([\element-hq#8328](matrix-org/matrix-react-sdk#8328)).
* Add the clipboard read permission for widgets ([\element-hq#9250](matrix-org/matrix-react-sdk#9250)). Contributed by @stefanmuhle.
* Make autocomplete pop-up wider in thread view ([\element-hq#9289](matrix-org/matrix-react-sdk#9289)).
* Fix soft crash around inviting invalid MXIDs in start DM on first message flow ([\element-hq#9281](matrix-org/matrix-react-sdk#9281)). Fixes matrix-org/element-web-rageshakes#15060 and matrix-org/element-web-rageshakes#15140.
* Fix in-reply-to previews not disappearing when swapping rooms ([\element-hq#9278](matrix-org/matrix-react-sdk#9278)).
* Fix invalid instanceof operand window.OffscreenCanvas ([\element-hq#9276](matrix-org/matrix-react-sdk#9276)). Fixes element-hq#23275.
* Fix memory leak caused by unremoved listener ([\element-hq#9273](matrix-org/matrix-react-sdk#9273)).
* Fix thumbnail generation when offscreen canvas fails ([\element-hq#9272](matrix-org/matrix-react-sdk#9272)). Fixes element-hq#23265.
* Prevent sliding sync from showing a room under multiple sublists ([\element-hq#9266](matrix-org/matrix-react-sdk#9266)).
* Fix tile crash around tooltipify links ([\element-hq#9270](matrix-org/matrix-react-sdk#9270)). Fixes element-hq#23253.
* Device manager - filter out nulled metadatas in device tile properly ([\element-hq#9251](matrix-org/matrix-react-sdk#9251)).
* Fix a sliding sync bug which could cause rooms to loop ([\element-hq#9268](matrix-org/matrix-react-sdk#9268)).
* Remove the grey gradient on images in bubbles in the timeline ([\element-hq#9241](matrix-org/matrix-react-sdk#9241)). Fixes element-hq#21651.
* Fix html export not including images ([\element-hq#9260](matrix-org/matrix-react-sdk#9260)). Fixes element-hq#22059.
* Fix possible soft crash from a race condition in space hierarchies ([\element-hq#9254](matrix-org/matrix-react-sdk#9254)). Fixes matrix-org/element-web-rageshakes#15225.
* Disable all types of autocorrect, -complete, -capitalize, etc on Spotlight's search field ([\element-hq#9259](matrix-org/matrix-react-sdk#9259)).
* Handle M_INVALID_USERNAME on /register/available ([\element-hq#9237](matrix-org/matrix-react-sdk#9237)). Fixes element-hq#23161.
* Fix issue with quiet zone around QR code ([\element-hq#9243](matrix-org/matrix-react-sdk#9243)). Fixes element-hq#23199.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
A-Widgets P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression X-Release-Blocker
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jryans @turt2live