Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add entitlements file for mic & camera permissions on macOS #11435

Merged
merged 2 commits into from
Nov 19, 2019
Merged

Add entitlements file for mic & camera permissions on macOS #11435

merged 2 commits into from
Nov 19, 2019

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Nov 19, 2019

Fixes #11151

@dbkr dbkr requested a review from a team November 19, 2019 19:03
turt2live
turt2live approved these changes Nov 19, 2019
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like you have a mix of tabs and spaces, but it looks valid to me. A bit annoying that they used empty tags rather than attributes or a different structure.

@dbkr
Copy link
Member Author

dbkr commented Nov 19, 2019

yeah, plist is a strange format

@dbkr dbkr merged commit a5daa14 into develop Nov 19, 2019
@awesome-michael awesome-michael mentioned this pull request Nov 27, 2019
Open
@t3chguy t3chguy deleted the dbkr/audio_video_entitlements_mac branch May 12, 2022 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turt2live turt2live turt2live approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot make calls with Catalina on Desktop
2 participants
@dbkr @turt2live