Support TypeScript for React components #12696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same treatment as matrix-org/matrix-react-sdk#4203
t3chguy
approved these changes
Mar 12, 2020
turt2live
force-pushed
the
travis/typescript-2
branch
from
cc86cb2
to
798d4da
Compare
t3chguy
approved these changes
Mar 12, 2020
jplatte
reviewed
Mar 26, 2020
| @@ -94,7 +94,7 @@ | |||
| "@babel/preset-typescript": "^7.7.4", | |||
| "@babel/register": "^7.7.4", | |||
| "@babel/runtime": "^7.7.6", | |||
| "@types/react": "^16.9.17", | |||
| "@types/react": "16.9", | |||
There was a problem hiding this comment.
Why is this no longer a caret dependency (also on matrix-org/matrix-react-sdk#4203)?
There was a problem hiding this comment.
because yarn is awful for two reasons: it doesn't default to caret when installing things, and we should be pinning our types to our react version. 16.9 still gets resolved the same as 16.9.x, which is compatible with carets.
There was a problem hiding this comment.
So 16.9, ^16.9 ^16.9.0 all get resolved differently? Also, if this is the correct treatment for @types/react, should @types/react-dom below also be updated?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same treatment as matrix-org/matrix-react-sdk#4203