Wire up electron download progress to toasts #16947
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey @t3chguy , does this mean there will be no download progress bar for encrypted media? |
|
With this work as it stands, it'd be near instant. More work needs to be done to hook it onto the download and decrypt process. Hence it being a draft. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires matrix-org/matrix-react-sdk#5863
Requires element-hq/element-desktop#184
Fixes element-hq/element-desktop#713
Fixes element-hq/element-desktop#699
Blocked on element-hq/element-desktop#727 - due to this issue only e2ee downloads work in EleDesktop - and those are "instantaneous" as they're just from in-memory blobs so this is somewhat untested and blocked as such.
Probably could do with a progress bar and other fanciness, potentially also merging all active downloads into a single toast maybe or something like that.
Here's what your changelog entry will look like:
✨ Features