CSS hacks to get topic to be chopped if it overflows, and also expand… #2287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the header when hovered over, to show the full topic
|
Can one of the admins verify this patch? |
|
matrix-org/matrix-react-sdk#486 is the companion |
|
@wmwragg Is this something you are still interested in pursuing? |
|
Thanks for making this contribution a while back. Since the code base has changed since this was opened, it no longer applies cleanly, and I don't think there's a need to keep it open in this state, as we can always find the code here again if needed. If you are still interested in pursuing this feature, please discuss with us in #riot-dev:matrix.org to find a good approach forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A companion branch matrix-org/matrix-react-sdk:wmwragg/room-header-styling also needs to be merged.
W A R N I N G
This should be checked before merging to make sure it's what you want. Be aware that if you want something different, then it'll probably have to be a refactor of the header code.
W A R N I N G
This fixes the overflow for long room topic causing the timeline to be scrollable left and right. It also fixes the issue of not being able to use long topic for user information, as they couldn't click on links in a long topic. An example of this would be the "Riot User Feedback" room.
I have removed the topics browser style tooltip, as it is no longer required, as the user just has to hover on the header to see the full topic now.
Signed-off-by: William Wragg wm.wragg@gmail.com