Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add .nvmrc to auto use lts version #22882

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

kecrily
Copy link

@kecrily kecrily commented Jul 18, 2022

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@kecrily kecrily requested a review from a team as a code owner July 18, 2022 15:09
@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label Jul 18, 2022
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Can we get more information in the PR description for what this is aiming to solve and how it helps?

@kecrily
Copy link
Author

kecrily commented Jul 20, 2022

I was having problems with the node latest version. So I switched to the LTS version.

And if someone is using the node version manager, then its package manager will automatically switch to the latest LTS version after .nvmrc is added. This takes the hassle out of manually switching versions and keeps the development environment as consistent as possible.

@t3chguy
Copy link
Member

t3chguy commented Jul 26, 2022

We don't suggest nvm anywhere, we should instead specify the minimum node version required in the package.json https://docs.npmjs.com/cli/v8/configuring-npm/package-json#engines

@t3chguy t3chguy added the T-Task Tasks for the team like planning label Jul 27, 2023
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ultimately I think this does no harm, thanks for your contribution

@t3chguy t3chguy enabled auto-merge (squash) July 27, 2023 13:05
auto-merge was automatically disabled January 8, 2024 12:36

Merge queue setting changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Tasks for the team like planning Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants