Make the registration page scrollable for small screens #23771
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonBrandner
approved these changes
Nov 15, 2022
t3chguy
reviewed
Nov 15, 2022
| @@ -60,7 +60,7 @@ | |||
| </head> | |||
| <body style="height: 100%; margin: 0;"> | |||
| <noscript>Sorry, Element requires JavaScript to be enabled.</noscript> <!-- TODO: Translate this? --> | |||
| <section id="matrixchat" style="height: 100%;" class="notranslate"></section> | |||
| <section id="matrixchat" style="height: 100%; overflow-y: auto" class="notranslate"></section> | |||
There was a problem hiding this comment.
We shouldn't be applying any rules here beyond what is necessary, especially as whole-page scrolling for what is nominally a full screen app is a bad time. The rule should be applied to the smallest effect needed, in the very components it affects. This will likely also break overscroll bounce on OSX and iOS as per the comment in the style file. Such a change could also really benefit from Percy testing.
|
Learned that this is the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19548.
Checklist
Do I need to sign off as an Element employee? ^^
This PR currently has none of the required changelog labels.
Add one of:
T-Deprecation,T-Enhancement,T-Defect,T-Taskto indicate what type of change this is plusX-Breaking-Changeif it's a breaking change.