Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure we actually wait for the login form to appear in loading-test #25287

Merged
merged 1 commit into from
May 5, 2023
Merged

Ensure we actually wait for the login form to appear in loading-test #25287

merged 1 commit into from
May 5, 2023

Conversation

andybalaam
Copy link
Contributor

@andybalaam andybalaam commented May 5, 2023 •
edited by github-actions bot
Loading

Fix #24769
(hopefully, again)

This change is marked as an internal change (Task), so will not be included in the changelog.

@andybalaam andybalaam added the T-Task Tasks for the team like planning label May 5, 2023
@andybalaam andybalaam marked this pull request as ready for review May 5, 2023 11:42
@andybalaam andybalaam requested a review from a team as a code owner May 5, 2023 11:42
@andybalaam andybalaam merged commit 1fb03c8 into develop May 5, 2023
@andybalaam andybalaam deleted the andybalaam/really-wait-in-loading-test branch May 5, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t3chguy t3chguy t3chguy approved these changes

@germain-gg germain-gg Awaiting requested review from germain-gg germain-gg is a code owner automatically assigned from element-hq/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flaky test loading-test.tsx
2 participants
@andybalaam @t3chguy