Add edit-button to context menu behind toggle #2725
Conversation
|
Can one of the admins verify this patch? |
| @@ -37,6 +37,9 @@ module.exports = React.createClass({ | |||
|
|
|||
| /* callback called when the menu is dismissed */ | |||
| onFinished: React.PropTypes.func, | |||
|
|
|||
| /* Edit Mesage functionality is enabled */ | |||
| editEnabled: false, | |||
| @@ -37,6 +37,9 @@ module.exports = React.createClass({ | |||
|
|
|||
| /* callback called when the menu is dismissed */ | |||
| onFinished: React.PropTypes.func, | |||
|
|
|||
| /* Edit Mesage functionality is enabled */ | |||
| editEnabled: false, | |||
pik
force-pushed
the
context-menu-edit-button
branch
from
ae82b0b
to
62c6341
Compare
|
sorry for the delay on this... this looks very promising indeed. we can't merge it until the js-sdk stuff appears, of course. it's going to be sufficiently invasive that I'd hide it behind a Labs flag until we're happy that it works though! |
|
Isn't "Redact" supposed to be the button to edit a message? I'm not familiar with the term "redact", my en-fr dictionary says that it the action to write/edit/modify. Personally I would prefer to have an "Edit" and "Delete" buttons. It's far more simple to understand than "Redact" and "Edit". |
|
@MightyCreak 'Redact' is a semi-undocumented feature that deletes a message's content. In the client, this makes the message disappear. My understanding is that the message ID is retained in database while the actual content is removed. I would argue that for accuracy's sake, 'redact' is more appropriate in english than 'delete'. What is actually happen when the 'redact' button is clicked is closer to marking a document out with a black marker, than to shredding the entire document. I do agree calling it 'delete' would be a little clearer from a user perspective. I would maybe suggest that this comes down to a question of how much we want to black-box the actuality functionality of what's happening. |
|
we now have edits via matrix-org/matrix-react-sdk#2952 and similar. thanks @pik for being 3 years ahead of the curve - i'm sorry we couldn't merge this at the time :( |
PR to add an editButton (hidden by default) to the riot-web client
TextualBodyshould receive theeditmessage and render aMessageEditorInputon action dispatch.Not sure where config toggles is/are riot-web so I should update the
editEnabledproperty to point to that, potentially it should be received from the server? That way it would be possible to run an experimental synapse witheditfunctionality and have a client with functional edit-mode without running a fork of vector-web.