Webpack3 (no es6 changes) #4800

MTRNord · 2017-08-15T22:30:01Z

This is optional PR which updates webpack to v3.x.x.

bundle.js size gets down to 8.4MB from about 9.0MB before and bundle.css changes from 3.3Kb to 12Kb.
(I personally think also it is slightly faster when building. Not saw any changes on the webpage in speed)

eqyiel · 2017-12-04T22:13:16Z

Is this still considered optional given that Webpack 1x's life support was switched off in April?

MTRNord · 2017-12-05T04:54:54Z

It says optional as I am not member of the riot Team :) I am just not in the Position to decide

t3chguy · 2017-12-18T22:49:21Z

/me wonders why no one wants to review this :P

pafcu · 2017-12-21T08:08:51Z

I think this might solve real issues: https://matrix.to/#/!DdJkzRliezrwpNebLk:matrix.org/%2415137819892616558FrkqI:matrix.org

Any chance of getting this merged?

MTRNord · 2018-01-26T06:04:04Z

Friendly bump😇

MTRNord · 2018-04-09T14:02:52Z

It might make sense to use the cacheDirectory option of babel-loader to speed up the build. Any opinions on this?

dbkr

So the context on this is that we'd been reluctant to introduce changes to the platform while we were trying to get things stable. Now 0.14 is, it's a better time to be looking at making changes like this.

I haven't actually tried to run this yet, but have commented on the two things I don't understand.

dbkr · 2018-04-20T16:00:09Z

.travis.yml

@@ -32,4 +32,4 @@ addons:
 install:
    # clone the deps with depth 1: we know we will only ever need that one
    # commit.
-    - scripts/fetch-develop.deps.sh --depth 1 && npm install
+    - npm install && scripts/fetch-develop.deps.sh --depth 1


I vaguely remember asking you about this back when you submitted the PR... if I did, I can't remember the conclusion though. Why is this necessary?

I think it was the CI being stupid. It works this way not the other way. But I have to admit I do not know if this still is required

It was propably the symlink issue that npm has which later got finished

dbkr · 2018-04-20T16:01:20Z

src/vector/index.html

+           htmlWebpackPlugin.files.js.splice(i, 1);
+        }
+       }
+       for (var i=0; i < htmlWebpackPlugin.files.js.length; i++) {


You're putting olm first? Why?

The array variable is unused.

Indents.

Because in webpack 3 they get randomly ordered which causes olm to sometimes not load. The old script relied on the case that the array is always ordered the same way.

2 and 3 can I fix after the weekend

@dbkr I am not sure about 3. Should I do 2 spaces or 4? the html uses 2 spaces. Or do you mean the if that is missing one space?

ah ok. Yeah, I can see how that would break. Generally all the indents should be 4 spaces.

I guess I will leave the html as is but fix the Js code in there

Also, I wonder if we should be using chunksSortMode for the ordering (although given the docs don't tell you anything about what the different modes do, perhaps your solution is better...)

dbkr · 2018-04-20T17:30:33Z

Just tried this and it looks like it's failing to run the postcss preprocessor?

ERROR in ./res/themes/status/css/status.scss
Module parse failed: /Users/dave/matrix/riot-web/res/themes/status/css/status.scss Unexpected character '@' (1:0)
You may need an appropriate loader to handle this file type.
SyntaxError: Unexpected character '@' (1:0)
    at Parser.pp$4.raise (/Users/dave/matrix/riot-web/node_modules/webpack/node_modules/acorn/dist/acorn.js:2221:15)
    at Parser.pp$7.getTokenFromCode (/Users/dave/matrix/riot-web/node_modules/webpack/node_modules/acorn/dist/acorn.js:2756:10)
    at Parser.pp$7.readToken (/Users/dave/matrix/riot-web/node_modules/webpack/node_modules/acorn/dist/acorn.js:2477:17)
    at Parser.pp$7.nextToken (/Users/dave/matrix/riot-web/node_modules/webpack/node_modules/acorn/dist/acorn.js:2468:15)
    at Parser.parse (/Users/dave/matrix/riot-web/node_modules/webpack/node_modules/acorn/dist/acorn.js:515:10)
    at Object.parse (/Users/dave/matrix/riot-web/node_modules/webpack/node_modules/acorn/dist/acorn.js:3098:39)
    at Parser.parse (/Users/dave/matrix/riot-web/node_modules/webpack/lib/Parser.js:902:15)
    at NormalModule.<anonymous> (/Users/dave/matrix/riot-web/node_modules/webpack/lib/NormalModule.js:104:16)
    at NormalModule.onModuleBuild (/Users/dave/matrix/riot-web/node_modules/webpack-core/lib/NormalModuleMixin.js:310:10)
    at nextLoader (/Users/dave/matrix/riot-web/node_modules/webpack-core/lib/NormalModuleMixin.js:275:25)
    at /Users/dave/matrix/riot-web/node_modules/webpack-core/lib/NormalModuleMixin.js:259:5
    at Storage.finished (/Users/dave/matrix/riot-web/node_modules/enhanced-resolve/lib/CachedInputFileSystem.js:38:16)
    at /Users/dave/matrix/riot-web/node_modules/graceful-fs/graceful-fs.js:78:16
    at FSReqWrap.readFileAfterClose [as oncomplete] (fs.js:511:3)

MTRNord · 2018-04-20T18:13:22Z

Hmm maybe some things got too old. I will after the weekend (I am on a Event and not at a PC) test this again and Do the needed changes

MTRNord · 2018-04-20T18:19:25Z

actually taking a quick google it seems it is a url-loader/css-loader aka webpack bug webpack-contrib/css-loader#355

MTRNord · 2018-04-20T18:26:05Z

The other option I see is that the config format has changed for postcss

MTRNord · 2018-04-20T18:44:49Z

@dbkr I updated the postcss to the newest version. Lets see if that helps. If you want you can test it. The CI seems to still work as before

MTRNord · 2018-04-26T18:39:22Z

/me now does some testing and will maybe tommorow make a webpack 4 PR for the future ^^ but seperate from this one to have a clean pr

MTRNord · 2018-04-26T19:17:38Z

ok I will test tommorrow. Setting up a fresh dev space after 600missing commits takes a lot of time. Installing deps takes on my hdd 1h. So I will have some commits to this tommorow propably

MTRNord · 2018-04-26T20:21:40Z

@dbkr the last commit should have fixed your error now. The reason was you have scss inside a node_modules folder and I excluded that to speed up the build. I now included only the needed folders from node_modules to fix the failing to load and at the same time not to need to include the hole node_modules

MTRNord · 2018-04-26T20:32:01Z

Tested it and it works for me.

MTRNord · 2018-04-26T20:35:59Z

Some sizes for thoose who like to know them:

bundle.css: 11,67KB
theme-status.css: 221,47KB
theme-light.css: 211,90KB
theme-dark.css: 213,02KB
olm.js: 451,56KB
bundle.js: 10,50MB
theme-status.js: 2,82KB
theme-light.js: 2,82KB
theme-dark.js: 2,82KB

MTRNord · 2018-04-27T09:36:04Z

#6620 tracks an update to webpack4

MTRNord added 5 commits August 15, 2017 22:56

Update to webpack3

3e7561f

Force olm to be loaded before all other .js files.

7ae2548

Change install order in tests to prevent NPM fail

809cb33

Fix Modal lacking needed functions

46b784b

Fix typo on import

6a2960f

MTRNord mentioned this pull request Nov 20, 2017

Upgrade to webpack 3 and add webpack-dashboard. #5616

Closed

rxl881 added a commit that referenced this pull request Nov 20, 2017

Pull in some changes from #4800

cc3413c

rxl881 requested a review from dbkr November 21, 2017 15:56

eqyiel mentioned this pull request Dec 4, 2017

TypeError: loaderUtils.getOptions is not a function #5749

Closed

rxl881 assigned dbkr Dec 5, 2017

dbkr removed their assignment Dec 7, 2017

MTRNord added 2 commits April 9, 2018 15:53

Merge branch 'develop' into webpack3_noES6

aca13d4

Update babel-loader version

ddee08b

dbkr reviewed Apr 20, 2018

View reviewed changes

MTRNord added 2 commits April 20, 2018 18:10

Merge branch 'develop' into webpack3_noES6

33b9d5e

Fix wrongly resolved merge conflict

68c2c5c

Update postcss and its dependencies for webpack3

1670703

MTRNord added 2 commits April 26, 2018 22:10

Fix webpack to fail with @imports

07a8505

Use include instead including all scss of node_modules

f8e4263

MTRNord closed this Oct 16, 2018

MTRNord deleted the webpack3_noES6 branch October 16, 2018 14:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Webpack3 (no es6 changes) #4800

Webpack3 (no es6 changes) #4800

MTRNord commented Aug 15, 2017 •

edited

Loading

eqyiel commented Dec 4, 2017

MTRNord commented Dec 5, 2017

t3chguy commented Dec 18, 2017

pafcu commented Dec 21, 2017

MTRNord commented Jan 26, 2018

MTRNord commented Apr 9, 2018 •

edited

Loading

dbkr left a comment

dbkr Apr 20, 2018

MTRNord Apr 20, 2018

MTRNord Apr 20, 2018 •

edited

Loading

dbkr Apr 20, 2018

MTRNord Apr 20, 2018

MTRNord Apr 20, 2018

dbkr Apr 20, 2018

MTRNord Apr 20, 2018

dbkr Apr 20, 2018

dbkr commented Apr 20, 2018

MTRNord commented Apr 20, 2018

MTRNord commented Apr 20, 2018

MTRNord commented Apr 20, 2018

MTRNord commented Apr 20, 2018 •

edited

Loading

MTRNord commented Apr 26, 2018

MTRNord commented Apr 26, 2018

MTRNord commented Apr 26, 2018

MTRNord commented Apr 26, 2018

MTRNord commented Apr 26, 2018

MTRNord commented Apr 27, 2018

Webpack3 (no es6 changes) #4800

Webpack3 (no es6 changes) #4800

Conversation

MTRNord commented Aug 15, 2017 • edited Loading

eqyiel commented Dec 4, 2017

MTRNord commented Dec 5, 2017

t3chguy commented Dec 18, 2017

pafcu commented Dec 21, 2017

MTRNord commented Jan 26, 2018

MTRNord commented Apr 9, 2018 • edited Loading

dbkr left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MTRNord Apr 20, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dbkr commented Apr 20, 2018

MTRNord commented Apr 20, 2018

MTRNord commented Apr 20, 2018

MTRNord commented Apr 20, 2018

MTRNord commented Apr 20, 2018 • edited Loading

MTRNord commented Apr 26, 2018

MTRNord commented Apr 26, 2018

MTRNord commented Apr 26, 2018

MTRNord commented Apr 26, 2018

MTRNord commented Apr 26, 2018

MTRNord commented Apr 27, 2018

MTRNord commented Aug 15, 2017 •

edited

Loading

MTRNord commented Apr 9, 2018 •

edited

Loading

MTRNord Apr 20, 2018 •

edited

Loading

MTRNord commented Apr 20, 2018 •

edited

Loading