Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run the Desktop app in a sandbox #7907

Merged
merged 4 commits into from
Dec 19, 2018
Merged

Run the Desktop app in a sandbox #7907

merged 4 commits into from
Dec 19, 2018

Commits on Dec 18, 2018

  1. Run the Desktop app in a sandbox

     * Turn off node integration in the electron renderer process
     * Enable the chromium sandbox to put the renderer into its own process
     * Expose just the ipc module with a preload script
     * Introduce a little IPC call wrapper so we can call into the
       renderer process and await on the result.
     * Use this in a bunch of places we previously used direct calls
       to electron modules.
     * Convert other uses of node, eg. use of process to derive the
       platform (just look at the user agent)
     * Strip out the desktopCapturer integration which doesn't appear
       to have ever worked (probably best to just wait until
       getDisplayMedia() is available in chrome at this point:
       https://github.com/vector-im/riot-web/issues/4880).
    dbkr committed Dec 18, 2018
    Configuration menu
    Copy the full SHA
    19f1489 View commit details
    Browse the repository at this point in the history
  2. lint

    dbkr committed Dec 18, 2018
    Configuration menu
    Copy the full SHA
    0c428ef View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0e58063 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2018

  1. Remove unused commented line

    dbkr committed Dec 19, 2018
    Configuration menu
    Copy the full SHA
    ff45dc6 View commit details
    Browse the repository at this point in the history