Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Buildkite for CI #9165

Merged
merged 6 commits into from
Mar 15, 2019
Merged

Use Buildkite for CI #9165

merged 6 commits into from
Mar 15, 2019

Conversation

turt2live
Copy link
Member

@turt2live turt2live commented Mar 14, 2019 •
edited
Loading

@turt2live
Copy link
Member Author

This PR doesn't have status checks yet because for some reason BuildKite isn't sending them (or can't?)

This was referenced Mar 14, 2019
Merged
Merged
@turt2live turt2live force-pushed the travis/buildkite branch 15 times, most recently from 8439b08 to 0d63181 Compare March 14, 2019 03:58
@turt2live turt2live requested a review from a team March 14, 2019 19:09
@jryans jryans self-requested a review March 15, 2019 10:34
jryans
jryans reviewed Mar 15, 2019
View reviewed changes
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking reasonable. I think my questions here have already been asked on the other repos, so I'll wait for those replies.

Nit: Buildkite seems to spell their name with lowercase "K".

scripts/fetch-develop.deps.sh Show resolved Hide resolved
@turt2live
Copy link
Member Author

Nit: Buildkite seems to spell their name with lowercase "K".

Can I just disagree with their branding and continue using bad habits?

(I'll go around fixing it)

@turt2live turt2live changed the title Use BuildKite for CI Use Buildkite for CI Mar 15, 2019
@turt2live
Fix downstream branch fetching
df7b617 
We should be giving the PR the best possible chance at passing the build.
@turt2live turt2live requested a review from jryans March 15, 2019 16:37
jryans
jryans approved these changes Mar 15, 2019
View reviewed changes
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, this one looks good to me! 😁

@turt2live turt2live merged commit 771909e into develop Mar 15, 2019
@turt2live turt2live deleted the travis/buildkite branch March 15, 2019 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jryans jryans jryans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@turt2live @jryans