Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate homeserver configuration prior to loading the app #9779

Merged
merged 22 commits into from May 23, 2019
Merged

Validate homeserver configuration prior to loading the app #9779

merged 22 commits into from May 23, 2019

Commits on May 3, 2019

  1. Validate default homeserver config before loading the app 

    Implements the process described here: #9290 (comment)

The expectation is that later layers (like the react-sdk) will make use of the `validated_discovery_config` option instead of interpreting the config themselves.

We intentionally block the UI from loading here to avoid races between discovery and the app loading.
    @turt2live
    turt2live committed May 3, 2019
    Configuration menu
    Copy the full SHA
    f08491c View commit details
    Browse the repository at this point in the history

  2. Use new js-sdk properties for getting discovery errors 

    Requires matrix-org/matrix-js-sdk#899
    @turt2live
    turt2live committed May 3, 2019
    Configuration menu
    Copy the full SHA
    5445632 View commit details
    Browse the repository at this point in the history

  3. Add note to self

    @turt2live
    turt2live committed May 3, 2019
    Configuration menu
    Copy the full SHA
    51941ea View commit details
    Browse the repository at this point in the history

  4. Move bulk of discovery processing to react-sdk

    @turt2live
    turt2live committed May 3, 2019
    Configuration menu
    Copy the full SHA
    c8caf67 View commit details
    Browse the repository at this point in the history

  5. Don't repackage the ValidatedDiscoveryConfig 

    It's usable as-is, and we can add things to it when we need to (ie: integrations).
    @turt2live
    turt2live committed May 3, 2019
    Configuration menu
    Copy the full SHA
    e7bf643 View commit details
    Browse the repository at this point in the history

  6. Add some clarity to the config options

    @turt2live
    turt2live committed May 3, 2019
    Configuration menu
    Copy the full SHA
    ab6ba0e View commit details
    Browse the repository at this point in the history

  7. Add a couple notes

    @turt2live
    turt2live committed May 3, 2019
    Configuration menu
    Copy the full SHA
    45caa8b View commit details
    Browse the repository at this point in the history

  8. Handle cases of no default server

    @turt2live
    turt2live committed May 3, 2019
    Configuration menu
    Copy the full SHA
    bf97fd6 View commit details
    Browse the repository at this point in the history

  9. Fix tests to use new server config options

    @turt2live
    turt2live committed May 3, 2019
    Configuration menu
    Copy the full SHA
    a5092dc View commit details
    Browse the repository at this point in the history

  10. Fix unit tests for new login 

    Supply a server config to the component and adjust the wait logic to be less of a race. The Login component will noop onPasswordLogin if it is "busy", and it is busy when it requests the login flows.
    @turt2live
    turt2live committed May 3, 2019
    Configuration menu
    Copy the full SHA
    fc5c93a View commit details
    Browse the repository at this point in the history

Commits on May 10, 2019

  1. Merge pull request #9496 from vector-im/travis/guests/block-ui 

    Validate default homeserver config before loading the app
    @turt2live
    turt2live committed May 10, 2019
    Configuration menu
    Copy the full SHA
    886828c View commit details
    Browse the repository at this point in the history

Commits on May 14, 2019

  1. Clarify comment on is_url and hs_url handling 

    We don't actually need to do anything because the app transparently handles this.

See #9290
    @turt2live
    turt2live committed May 14, 2019
    Configuration menu
    Copy the full SHA
    7f5589c View commit details
    Browse the repository at this point in the history

  2. Flag the validated config as the default config 

    For use in the rest of the app.

See #9290
    @turt2live
    turt2live committed May 14, 2019
    Configuration menu
    Copy the full SHA
    68a7550 View commit details
    Browse the repository at this point in the history

  3. Show most homeserver options on the mobile guide 

    This doesn't cover default_server_name because that pulls in a questionable amount of JS.

See #9290
    @turt2live
    turt2live committed May 14, 2019
    Configuration menu
    Copy the full SHA
    559416d View commit details
    Browse the repository at this point in the history

  4. Do a simple .well-known lookup for default_server_name for mobile guide

    @turt2live
    turt2live committed May 14, 2019
    Configuration menu
    Copy the full SHA
    22cc33e View commit details
    Browse the repository at this point in the history

Commits on May 16, 2019

  1. Merge pull request #9719 from vector-im/travis/wk/clarify_is_hs_url 

    Clarify comment on is_url and hs_url handling
    @turt2live
    turt2live committed May 16, 2019
    Configuration menu
    Copy the full SHA
    51f5671 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #9721 from vector-im/travis/wk/fallback_hs 

    Flag the validated config as the default config
    @turt2live
    turt2live committed May 16, 2019
    Configuration menu
    Copy the full SHA
    39d1293 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into travis/feature/wellknown2

    @turt2live
    turt2live committed May 16, 2019
    Configuration menu
    Copy the full SHA
    1ac5df3 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2019

  1. Merge pull request #9726 from vector-im/travis/wk/mobileguide 

    Show resolved homeserver configuration on the mobile guide
    @turt2live
    turt2live committed May 17, 2019
    Configuration menu
    Copy the full SHA
    7a65dc9 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2019

  1. Merge branch 'develop' into travis/feature/wellknown2

    @turt2live
    turt2live committed May 21, 2019
    Configuration menu
    Copy the full SHA
    fa9d2a8 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2019

  1. Update copyright

    @turt2live
    turt2live committed May 23, 2019
    Configuration menu
    Copy the full SHA
    b772bc7 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into travis/feature/wellknown2

    @turt2live
    turt2live committed May 23, 2019
    Configuration menu
    Copy the full SHA
    26d8056 View commit details
    Browse the repository at this point in the history