Hide guest functions on the welcome page if not logged in #9957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turt2live
added a commit
to matrix-org/matrix-react-sdk
that referenced
this pull request
Jun 4, 2019
See element-hq/element-web#9957 The two hacks introduced here are for different reasons, mostly related to the welcome page. If you land directly on the welcome page, the app's lifecycle is highly unlikely to have a bootstrapped client. This results in the loggedIn class being false. When the client is later set up (loaded from session, new guest account registered, etc) the context fails to update for the EmbeddedPage, and we need to give it a kick to re-render. It's arguable if we should even keep using the context here.
jryans
approved these changes
Jun 5, 2019
| @@ -169,9 +178,9 @@ <h4 class="mx_Header_subtitle">_t("Decentralised, encrypted chat & collabora | |||
| <!-- The comments below are meant to be used by Ansible as a quick way | |||
| to strip out the marked content when desired. | |||
| See https://github.com/vector-im/riot-web/issues/8622. | |||
| TODO: Convert to config option if possible. --> | |||
| TODO: Strip out these comments and rely on the guest flag --> | |||
There was a problem hiding this comment.
Could you file a new issue to do that? It seems much cleaner, but also likely to be forgotten...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9546
Requires matrix-org/matrix-react-sdk#3066