Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.16 - Polls are not enabled #1241

Closed
daedric7 opened this issue Sep 6, 2023 · 1 comment · Fixed by #1246
Closed

v0.16 - Polls are not enabled #1241

daedric7 opened this issue Sep 6, 2023 · 1 comment · Fixed by #1246
Assignees
@bmarty
Labels
A-Feature flags A-Polls O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@daedric7
Copy link

daedric7 commented Sep 6, 2023

Steps to reproduce

  1. Have someone or yourself in another client start a poll
  2. Element X shows "Unsupported Event"

Outcome

What did you expect?

A Poll

What happened instead?

Unsupported event.

In

https://matrix.to/#/!aCvOWKNDeXXpPgquKq:matrix.org/$qTdCinvFCy32_iNPSPv4Amo0wCTi_QdnvhifL2Zn9QQ?via=matrix.org&via=envs.net&via=element.io

@jorgem:element.io Informed that Polls are behind a dev option screen, which is not accessible in Release.

Screenshot_20230906-225806_Element X
Screenshot_20230906-225748_Element

Your phone model

OP7

Operating system version

Android 13

Application version and app store

Element X v0.1.3

Homeserver

aguiarvieira.pt

Will you send logs?

No

Are you willing to provide a PR?

No
@daedric7 daedric7 added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Sep 6, 2023
@bmarty bmarty self-assigned this Sep 7, 2023
@bmarty
Copy link
Member

bmarty commented Sep 7, 2023

You're right, the feature is not enabled in prod. I take the point.

@bmarty bmarty added S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience A-Polls A-Feature flags Z-Schedule labels Sep 7, 2023
bmarty added a commit that referenced this issue Sep 7, 2023
@bmarty
To avoid mistake, FeatureFlags does not have defaultValue set to tr…
74e3cc9 
…ue, and `StaticFeatureFlagProvider` return the default value.

This fixes #1241.
@bmarty bmarty mentioned this issue Sep 7, 2023
Merged
14 tasks
bmarty added a commit that referenced this issue Sep 7, 2023
@bmarty
To avoid mistake, FeatureFlags does not have defaultValue set to tr…
aacfa0d 
…ue, and `StaticFeatureFlagProvider` return the default value.

This fixes #1241.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmarty bmarty

Labels
A-Feature flags A-Polls O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/bma/enable polls element-hq/element-x-android
2 participants
@bmarty @daedric7