Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loading spinner when selecting different options on the room notifications setting page #1647

Closed
callumu opened this issue Oct 26, 2023 · 3 comments · Fixed by #3022
Closed

Loading spinner when selecting different options on the room notifications setting page #1647

callumu opened this issue Oct 26, 2023 · 3 comments · Fixed by #3022
Assignees
@bmarty @callumu
Labels
A-Notifications A-Performance A-Settings O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-Polish

Comments

@callumu
Copy link

callumu commented Oct 26, 2023

Steps to reproduce

Room details page -> Notifications -> change any option

Outcome

This should just be instant with no spinner or flickering

Untitled.mp4

Your phone model

No response

Operating system version

No response

Application version and app store

No response

Homeserver

No response

Will you send logs?

Yes

Are you willing to provide a PR?

Yes
@callumu callumu added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Oct 26, 2023
@callumu callumu self-assigned this Oct 26, 2023
@kittykat kittykat added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely A-Performance A-Settings A-Notifications labels Oct 27, 2023
@jmartinesp
Copy link
Contributor

This is sending some requests to the homeserver, so it can't be instant. It can be quite fast though, and we might be able to debounce the spinner so it doesn't appear most of the time.

@kittykat
Copy link
Contributor

@callumu would it work if we showed the spinner for a minimum amount of time so that it didn't flicker?

@kittykat kittykat mentioned this issue Nov 23, 2023
Open
@callumu
Copy link
Author

callumu commented Nov 27, 2023

@callumu would it work if we showed the spinner for a minimum amount of time so that it didn't flicker?

Yes that would be a good solution

@bmarty bmarty self-assigned this Jun 12, 2024
bmarty added a commit that referenced this issue Jun 12, 2024
@bmarty
Ensure that setting change is taken at least 300ms to avoid dialog fl…
c98863a 
…ickering (#1647)
@bmarty bmarty mentioned this issue Jun 12, 2024
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmarty bmarty

@callumu callumu

Labels
A-Notifications A-Performance A-Settings O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-Polish
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve UX on notification setting changes element-hq/element-x-android
5 participants
@kittykat @jmartinesp @bmarty @manuroe @callumu