Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll to end of timeline when sending a new message #1877

Closed
Tracked by #2212
ganfra opened this issue Nov 23, 2023 · 14 comments · Fixed by #1879 or #2035
Closed
Tracked by #2212

Scroll to end of timeline when sending a new message #1877

ganfra opened this issue Nov 23, 2023 · 14 comments · Fixed by #1879 or #2035
Assignees
Labels
A-Send messages A-Timeline T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Comments

@ganfra
Copy link
Contributor

ganfra commented Nov 23, 2023

As a user that has send a message I want the timeline to scroll to that message at the end of the timeline so that I can have a look at what I just send.

@rom4nik
Copy link
Contributor

rom4nik commented Nov 24, 2023

If I may chime in, this sounds like it would make reading message backlogs and sending replies as I'm reading much more inconvenient, unless there's a reliable "back to last (un)read" feature coming too, to quickly jump back to where I was right before that automatic scroll.

@Aquathing
Copy link

unless there's a reliable "back to last (un)read" feature coming too

I think you can (or, rather, will be able to) click on the message you replied to in order to go back up.

ganfra added a commit that referenced this issue Nov 28, 2023
…croll_send

Timeline : Scroll to end of timeline when sending a new message #1877
@VolkerJunginger
Copy link

Only working for text-messages. Should have the same behaviour w. any message.

@bmarty
Copy link
Member

bmarty commented Dec 13, 2023

Only working for text-messages. Should have the same behaviour w. any message.

It's not working for images for instance since there is no local echo support when sending images right now on the SDK.
So it's linked to matrix-org/matrix-rust-sdk#1732

@VolkerJunginger
Copy link

Can't you just scroll down when the message has been send?

@ganfra
Copy link
Contributor Author

ganfra commented Dec 13, 2023

This sounds like a bad idea for a media which can take time to get back from sync. And scrolling to the bottom as soon as we hit the send button is not great neither to me. So not sure what we can do on this for now.

@bmarty
Copy link
Member

bmarty commented Dec 13, 2023

The app could also move to the bottom of the timeline as soon as there is a new message sent by the user (with the side effect that it will scroll even if the user has sent the message from another session - which could be declared "acceptable" I think).

@manuroe
Copy link
Member

manuroe commented Dec 14, 2023

EIX uses the stick at bottom even for incoming messages

@manuroe
Copy link
Member

manuroe commented Dec 14, 2023

@VolkerJunginger will come back to the solution we should use on both platforms.

@bmarty
Copy link
Member

bmarty commented Dec 14, 2023

I have tested what's the behavior on WhatsApp:

  • WhatsApp mobile: scroll to the history
  • send a message from WhatsApp Desktop (same account)
    The timeline is scrolling to live on WhatsApp mobile.

This is the same if you do it with exchange the 2 WhatsApp clients.

I guess we can do the same on Element then, but I let @VolkerJunginger confirm this.

@VolkerJunginger
Copy link

The WhatsApp behaviour is the same we did on iOS, right? If so lets go with this for now.

@ganfra
Copy link
Contributor Author

ganfra commented Dec 14, 2023

Not sure this is exactly what is done on iOS. @pixlwave do you if it automatically scrolls if you receive a message you sent from another session?

@pixlwave
Copy link
Contributor

pixlwave commented Dec 14, 2023

Yep @ganfra is correct, we don't scroll for the user's other sessions. We basically send a signal to scroll to bottom whenever the app queues a text message or finished sending some form of media.

bmarty added a commit that referenced this issue Dec 14, 2023
…er device #1877.

This fixes the issue that the timeline does not scroll when sending an attachment to the room, since there is no local echo (yet) for such event.
bmarty added a commit that referenced this issue Dec 15, 2023
…er device #1877.

This fixes the issue that the timeline does not scroll when sending an attachment to the room, since there is no local echo (yet) for such event.
@bmarty
Copy link
Member

bmarty commented Dec 19, 2023

For posterity, I discover now that it's a setting on Element Web:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Send messages A-Timeline T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
7 participants