Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Be able to send image from keyboard #1977

Closed
bmarty opened this issue Dec 8, 2023 · 0 comments · Fixed by #2131
Closed

Be able to send image from keyboard #1977

bmarty opened this issue Dec 8, 2023 · 0 comments · Fixed by #2131
Labels
A-Composer Android OS - nice to have Features offered by the Android OS which would be nice to implement in Element O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Comments

@bmarty
Copy link
Member

bmarty commented Dec 8, 2023

When trying to send an image from the keyboard, the app is displaying an error:

image

The image should be sent as a regular image, as it was the case for EA. It will probably require some changes on the the rich text editor library.

For reference, this is the EA implementation for the RTE: element-hq/element-android#8185
@bmarty bmarty added S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements O-Occasional Affects or can be seen by some users regularly or most users rarely A-Composer Android OS - nice to have Features offered by the Android OS which would be nice to implement in Element labels Dec 8, 2023
@bmarty bmarty mentioned this issue Dec 13, 2023
Closed
bmarty added a commit that referenced this issue Dec 29, 2023
@bmarty
Add support for sending images from the keyboard #1977
bc6d47b
@bmarty bmarty mentioned this issue Dec 29, 2023
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Composer Android OS - nice to have Features offered by the Android OS which would be nice to implement in Element O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for sending images from the keyboard element-hq/element-x-android
1 participant
@bmarty